-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/elastic/mito from 1.1.0 to 1.2.0 #35572
Bump github.com/elastic/mito from 1.1.0 to 1.2.0 #35572
Conversation
Bumps [github.com/elastic/mito](https://github.com/elastic/mito) from 1.1.0 to 1.2.0. - [Commits](elastic/mito@v1.1.0...v1.2.0) --- updated-dependencies: - dependency-name: github.com/elastic/mito dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
I was concerned this would happen with making auto-upgrade a thing. There are docs that needed to be updated. |
Any suggestions on how to avoid this? In general I like that we automated this, but there isn't a great way to know if other changes are necessary when one of these PRs is created. Ideally we'd have codeowners for each dependency but I don't think the codeowners syntax supports that. |
I have what is likely an unpopular opinion, so I don't propose it as a solution (I don't see a good solution); I don't think robots should be making these calls since event with patch-level updates there is potential for breaking client code when a dep is upgraded either because of a failure of the dep's author to properly mark changes according to semver or because of Hyrum's Law. IMO versions should be bumped when they are needed to be bumped, this should really always be the decision of an informed human and at most should be triggered by the raising of an issue rather than the posting of a pull request. |
That's a reasonable opinion, but despite the problems you described I still think the automation is valuable as we have shipped bugs that were fixed in https://github.com/elastic/elastic-agent-libs but the fix was propagated to every affected repository. Automating this is much better than relying on every team to monitor new releases. There is also a use case in picking up security fixes in transient dependencies in some of these packages, where upgrading stops us from getting requests to explain whether we are vulnerable to certain CVEs. The dependabot configuration is fairly flexible, so we can could set it to ignore certain dependencies that we know require more careful attention for upgrades. I wouldn't be opposed to setting mito as an ignored dependency to ensure you and the SEI team own the updates instead of an automated PR. https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#ignore |
* Bump github.com/elastic/mito from 1.1.0 to 1.2.0 Bumps [github.com/elastic/mito](https://github.com/elastic/mito) from 1.1.0 to 1.2.0. - [Commits](elastic/mito@v1.1.0...v1.2.0) --- updated-dependencies: - dependency-name: github.com/elastic/mito dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update NOTICE.txt --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Bumps github.com/elastic/mito from 1.1.0 to 1.2.0.
Commits
6c756d4
lib: add support for md5 hashingDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)