packetbeat/beater: prevent double close of pb.done #35324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Packetbeat
Team:Security-External Integrations
8.8-candidate
bugfix
backport-v8.7.0
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This comment was marked as outdated.
This comment was marked as outdated.
In some circumstances when a managed instance of packetbeat is restarted Stop will panic with close of closed channel. This appears to be happening because on reload the sniffer may have returned an error, closing pb.done. If the packetbeat instance is then stopped done is closed a second time. So ensure that all closes are protected by pb.stopOnce.
andrewkroh
approved these changes
May 4, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 4, 2023
In some circumstances when a managed instance of packetbeat is restarted Stop will panic with close of closed channel. This appears to be happening because on reload the sniffer may have returned an error, closing pb.done. If the packetbeat instance is then stopped, done is closed a second time. So ensure that all closes are protected by pb.stopOnce. (cherry picked from commit 30e633c)
efd6
added a commit
that referenced
this pull request
May 4, 2023
In some circumstances when a managed instance of packetbeat is restarted Stop will panic with close of closed channel. This appears to be happening because on reload the sniffer may have returned an error, closing pb.done. If the packetbeat instance is then stopped, done is closed a second time. So ensure that all closes are protected by pb.stopOnce. (cherry picked from commit 30e633c) Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
In some circumstances when a managed instance of packetbeat is restarted Stop will panic with close of closed channel. This appears to be happening because on reload the sniffer may have returned an error, closing pb.done. If the packetbeat instance is then stopped, done is closed a second time. So ensure that all closes are protected by pb.stopOnce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In some circumstances when a managed instance of packetbeat is restarted Stop will panic with close of closed channel. This appears to be happening because on reload the sniffer may have returned an error, closing
pb.done. If the packetbeat instance is then stopped done is closed a second time. So ensure that all closes are protected bypb.stopOnce.Why is it important?
The current situation leads to contamination of the logs with useless fatal error lines. These do no indicate a failure since they are happening when packetbeat is shutting down, but are a debugging distraction.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs