-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/input/httpjson: add benchmarks #35138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Team:Security-External Integrations
backport-skip
Skip notification from the automated backport with mergify
labels
Apr 20, 2023
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Apr 20, 2023
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
efd6
force-pushed
the
x-httpjson-benchmarks
branch
from
April 27, 2023 00:12
d1c3e5b
to
21335d6
Compare
/test |
efd6
force-pushed
the
x-httpjson-benchmarks
branch
2 times, most recently
from
May 24, 2023 22:14
43de5f7
to
003afcb
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Also rename test cases to reduce stutter and improve test debug ergonomics.
efd6
force-pushed
the
x-httpjson-benchmarks
branch
from
June 7, 2023 04:04
003afcb
to
aafaef5
Compare
/test |
kgeller
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.9-candidate
backport-skip
Skip notification from the automated backport with mergify
enhancement
Filebeat
Filebeat
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds benchmarking for the HTTPJSON input as a prelude to a refactor and revision. It also refactors the structure of the testing code to separate the test table from the test function; this is partly to allow sharing of test cases between the tests and benchmarks, and partly for clarity.
Test names are altered to reduce stutter and make direct copy/paste of the name in terminal output from
go test
findable in the Go source.Why is it important?
This is needed to allow a comparison between HTTPJSON and the new CEL input (the original reason), to guard against perf regressions in an upcoming revision, and to allow us to direct performance improvement work based on evidence. The formatting changes in the test table are QoL.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Run
go test
in x-pack/filebeat/input/httpjson, optionally with-bench .
and friends.Related issues
Use cases
Screenshots
Logs