Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report FQDN on host.name enabled by a feature flag #34456

Merged
merged 72 commits into from
Mar 20, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
928bc15
wip
AndersonQ Feb 2, 2023
49b89c4
wip
AndersonQ Feb 2, 2023
3794a07
wip
AndersonQ Feb 6, 2023
d1b5207
something is broken
AndersonQ Feb 7, 2023
a6e6639
debug logs
AndersonQ Feb 7, 2023
f234781
avoid panics
AndersonQ Feb 7, 2023
cf14a68
wip broken
AndersonQ Feb 7, 2023
34f2b22
wip - perhaps fixed double configuring features
AndersonQ Feb 8, 2023
bd20db1
using triggers to know what changed
AndersonQ Feb 9, 2023
e7bec79
it works, but the agent-client is sending feature changes every time
AndersonQ Feb 10, 2023
700952d
debug logs
AndersonQ Feb 13, 2023
4976c23
more debug logs
AndersonQ Feb 13, 2023
e04d543
wip
AndersonQ Feb 13, 2023
9dc4895
it works
AndersonQ Feb 22, 2023
2c8cb44
remove debug logs
AndersonQ Feb 24, 2023
50dc5b4
fix after rebase
AndersonQ Feb 24, 2023
ab468d1
update elastic-agent-client and make notice
AndersonQ Feb 27, 2023
0aacfd7
license headres
AndersonQ Mar 1, 2023
57f2279
Add TODO for Winlogbeat FQDN implementation
ycombinator Mar 7, 2023
682e9fa
Removing unnecesary code
ycombinator Mar 7, 2023
6f143e5
Use RWMutex for greater read efficiency
ycombinator Mar 7, 2023
0b14c40
Move mutex inside struct
ycombinator Mar 7, 2023
05279e5
Better error handling
ycombinator Mar 7, 2023
1bb2211
Temporarily updating dependency
ycombinator Mar 7, 2023
4a9c251
Always store FQDN in Beat info
ycombinator Mar 7, 2023
3a2eac6
Set hostname in monitoring registries after FQDN config has been eval…
ycombinator Mar 7, 2023
948e03f
Pass down FQDN flag from add_host_metadata processor
ycombinator Mar 7, 2023
0077053
Better error handling
ycombinator Mar 7, 2023
e8a6249
Add temporary notice override
ycombinator Mar 7, 2023
d7cbd45
Changing log level
ycombinator Mar 7, 2023
1cd2534
Update dependency on elastic-agent-system-metrics
ycombinator Mar 7, 2023
9ee01d4
Running go mod tidy
ycombinator Mar 7, 2023
8bf6ccf
Update elastic-agent-system-metrics dependency version
ycombinator Mar 8, 2023
d56f1f4
Add feature flags configuration section to reference yml
ycombinator Mar 8, 2023
bc195d5
Bump up version of elastic-agent-client depdendency
ycombinator Mar 8, 2023
c2f9610
Updating reference file
ycombinator Mar 8, 2023
c634c52
Updating reference files
ycombinator Mar 8, 2023
f302f12
Move feature flags setting into same method where log level setting i…
ycombinator Mar 8, 2023
07427c6
Updating docs
ycombinator Mar 8, 2023
0e1d221
Adding CHANGELOG entry
ycombinator Mar 8, 2023
a607532
Remove replace directive for go-sysinfo
ycombinator Mar 9, 2023
fb2cbb3
Running go mod tidy
ycombinator Mar 9, 2023
08578e6
Remove replace directive for elastic-agent-client dependency
ycombinator Mar 9, 2023
392e995
Remove personal repos from overrides.json
ycombinator Mar 9, 2023
fce4ef4
Updating NOTICE
ycombinator Mar 9, 2023
cf2ad11
Bump up version for elastic-agent-client dependency
ycombinator Mar 9, 2023
5a3981b
Update NOTICE
ycombinator Mar 9, 2023
8b00241
Removing noisy debug logging
ycombinator Mar 9, 2023
63950dc
Removing commented out code that's not needed
ycombinator Mar 9, 2023
86b4618
Fixing error message
ycombinator Mar 9, 2023
444db78
Make default flag setting more explicit
ycombinator Mar 9, 2023
e8fa727
Adding config with no features to unit test
ycombinator Mar 9, 2023
1213ab3
Add helper method to beat.Info for returning FQDN-aware hostname
ycombinator Mar 9, 2023
db1a51f
Adding license header to test file
ycombinator Mar 9, 2023
4ff2c87
Remove use of errors package
ycombinator Mar 9, 2023
1af8780
Check error from data.Put
ycombinator Mar 9, 2023
d164036
Expire add_host_metadata cache immediately on FQDN feature flag value…
ycombinator Mar 10, 2023
c7ee641
Fix casing in error message
ycombinator Mar 10, 2023
7520fac
Have callback registration function accept ID
ycombinator Mar 10, 2023
cd8f901
Fixing go formatting
ycombinator Mar 10, 2023
a7e4145
Account for feature flags in TestManagerV2 test
ycombinator Mar 11, 2023
542d54a
Update logging for unit changes
ycombinator Mar 11, 2023
70f654f
Remove TODO from wineventlog code
ycombinator Mar 11, 2023
1a82458
Updating dependency
ycombinator Mar 11, 2023
4757a5a
Include shared file in docs
ycombinator Mar 11, 2023
77772ca
Bumping dependency on elastic-agent-client
ycombinator Mar 15, 2023
66a748c
Include features config in diagnostics output
ycombinator Mar 16, 2023
fd09ab8
Update comment
ycombinator Mar 16, 2023
4444a16
Updating NOTICE
ycombinator Mar 16, 2023
4a4b223
Re-formatting
ycombinator Mar 16, 2023
b0e457f
Running make update
ycombinator Mar 16, 2023
920a61e
Merge branch 'main' into 1070-fqdn-feature-flag
ycombinator Mar 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing go formatting
  • Loading branch information
ycombinator committed Mar 20, 2023
commit cd8f90104d5f9b99175fb0c6d37fd669fe86336e
2 changes: 1 addition & 1 deletion libbeat/features/features.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func FQDN() bool {
// AddFQDNOnChangeCallback takes a callback function that will be called with the new and old values
// of `flags.fqdnEnabled` whenever it changes. It also takes a string ID - this is useful
// in calling `RemoveFQDNOnChangeCallback` to de-register the callback.
func AddFQDNOnChangeCallback(cb boolValueOnChangeCallback, id string) error {
func AddFQDNOnChangeCallback(cb boolValueOnChangeCallback, id string) error {
flags.mu.Lock()
defer flags.mu.Unlock()

Expand Down
8 changes: 4 additions & 4 deletions libbeat/processors/add_host_metadata/add_host_metadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ type addHostMetadata struct {
time.Time
sync.Mutex
}
data mapstr.Pointer
geoData mapstr.M
config Config
logger *logp.Logger
data mapstr.Pointer
geoData mapstr.M
config Config
logger *logp.Logger
}

const (
Expand Down