-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat][CometD] Resolve Retry Error Handling #34327
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all the change looks good to me but I'd like to ask another pair of eyes from someone who knows the area very well.
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
Unless there is anything more, we should merge @agithomas @rdner @efd6 ? |
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* resolve retry error handling * add retry in input worker * added unit test for testing EOF error retry in cometd input * resolve golangci-lint errors * introduce SObject extraction as well * improved logging * salesforce force fully closing connection for the case of timeouts * channel creation for each new iteration to avoid unnecessary channel close panics
What does this PR do?
Filebeat CometD input is closing input worker in case of client-server connection issue with EOF error.
Current forked bayeux library is sending error message while any connection issues from salesforce side. which in return CometD is assuming it to be un recoverable error and closing the input worker.
This PR contains draft changes for handling above mentioned issue.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Logs