Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to github.com/elastic/go-sysinfo v1.9.0 #33864

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Nov 29, 2022

What does this PR do?

Update to https://github.com/elastic/go-sysinfo/releases/tag/v1.9.0

Why is it important?

Various fixes. Some related to OS metadata collection.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 29, 2022
@andrewkroh andrewkroh force-pushed the feature/deps-go-sysinfo-1-9-0 branch from a2e6932 to ac55c43 Compare November 29, 2022 13:40
@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewkroh? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 29, 2022
@andrewkroh andrewkroh marked this pull request as ready for review November 29, 2022 13:41
@andrewkroh andrewkroh requested a review from a team as a code owner November 29, 2022 13:41
@andrewkroh andrewkroh requested review from cmacknz and fearful-symmetry and removed request for a team November 29, 2022 13:41
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-29T18:59:53.347+0000

  • Duration: 101 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 24116
Skipped 1954
Total 26070

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh
Copy link
Member Author

/test

@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/deps-go-sysinfo-1-9-0 upstream/feature/deps-go-sysinfo-1-9-0
git merge upstream/main
git push upstream feature/deps-go-sysinfo-1-9-0

@andrewkroh andrewkroh force-pushed the feature/deps-go-sysinfo-1-9-0 branch from ac55c43 to e0c76bd Compare November 29, 2022 18:59
@andrewkroh
Copy link
Member Author

A few E2E tests failed, but it did not look related to this change.

--- Failed steps:

Scenario: Metrics collection stops when the pod is stopped # features/metricbeat.feature:7
Given "metricbeat" is running with "hints enabled" # features/metricbeat.feature:8
Error: Error response from daemon: No such image: docker.elastic.co/beats/metricbeat:8.6.0-SNAPSHOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants