Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auditbeat] Make auditbeat resumeable when config is locked and immutable is set #32498

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jul 26, 2022

What does this PR do?

If auditd config is locked and the immutable option is set, all the configuration setup is ignored to be able to resume events processing onces the pid is changed.

Why is it important?

This way auditbeat can be stopped and restarted without requiring a system restart as far as the configuration does not need to change.

Chnagelog not added since this is modifying a feature added for 8.4 that is still not released.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 26, 2022
@marc-gr marc-gr requested a review from andrewkroh July 26, 2022 07:37
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-26T15:57:52.929+0000

  • Duration: 53 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 573
Skipped 81
Total 654

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr added the v8.4.0 label Jul 26, 2022
@marc-gr marc-gr merged commit 8710715 into elastic:main Jul 26, 2022
@marc-gr marc-gr deleted the auditbeat-immut branch July 26, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants