-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack Monitoring] Switch cgroup memory fields to keyword #32197
Merged
matschaffer
merged 3 commits into
elastic:main
from
matschaffer:beats-31765-cgroup-memory-mapping
Jul 11, 2022
Merged
[Stack Monitoring] Switch cgroup memory fields to keyword #32197
matschaffer
merged 3 commits into
elastic:main
from
matschaffer:beats-31765-cgroup-memory-mapping
Jul 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-nodes-stats.html they should be strings. data.go appears to also consider them strings, so just updating the field definitions might be enough.
Collaborator
klacabane
approved these changes
Jul 5, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
* [Stack Monitoring] Switch cgroup memory fields to keyword Per https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-nodes-stats.html they should be strings. data.go appears to also consider them strings, so just updating the field definitions might be enough. * make update * Update changelog (cherry picked from commit 1f2895e) # Conflicts: # metricbeat/module/elasticsearch/fields.go
matschaffer
added a commit
that referenced
this pull request
Jul 13, 2022
… to keyword (#32295) * [Stack Monitoring] Switch cgroup memory fields to keyword (#32197) * [Stack Monitoring] Switch cgroup memory fields to keyword Per https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-nodes-stats.html they should be strings. data.go appears to also consider them strings, so just updating the field definitions might be enough. * make update * Update changelog (cherry picked from commit 1f2895e) # Conflicts: # metricbeat/module/elasticsearch/fields.go * make update * Remove unrelated changelog entries * Put trailing lines back Co-authored-by: Mat Schaffer <mat@elastic.co>
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… fields to keyword (elastic#32295) * [Stack Monitoring] Switch cgroup memory fields to keyword (elastic#32197) * [Stack Monitoring] Switch cgroup memory fields to keyword Per https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-nodes-stats.html they should be strings. data.go appears to also consider them strings, so just updating the field definitions might be enough. * make update * Update changelog (cherry picked from commit 05417e4) # Conflicts: # metricbeat/module/elasticsearch/fields.go * make update * Remove unrelated changelog entries * Put trailing lines back Co-authored-by: Mat Schaffer <mat@elastic.co>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* [Stack Monitoring] Switch cgroup memory fields to keyword Per https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-nodes-stats.html they should be strings. data.go appears to also consider them strings, so just updating the field definitions might be enough. * make update * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.3.0
Automated backport with mergify
bug
Feature:Stack Monitoring
Team:Infra Monitoring UI - DEPRECATED
Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes cgroup memory fields from long to string.
Per https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-nodes-stats.html they should be strings. data.go appears to also consider them strings, so just updating the field definitions might be enough.
Why is it important?
With the current mapping as
long
, ingest of elasticsearch node data can fail when elasticsearch responds with a string like'max'
.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works(used existing suite)CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
So far I can't figure out how to get ES to respond with
max
in the cgroup memory setting:I'll need that before I can advise on how to test this.
Related issues
Use cases
Stack Monitoring
Logs
Without this change you can get this error on ingest:
(from forum)