-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mutex unlocking in monitoring registry #30638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Mar 2, 2022
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Mar 2, 2022
This pull request does not have a backport label. Could you fix it @kvch? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
Skip notification from the automated backport with mergify
label
Mar 2, 2022
kvch
added
backport-7.17
Automated backport to the 7.17 branch with mergify
backport-v8.0.0
Automated backport with mergify
backport-v8.1.0
Automated backport with mergify
bug
and removed
backport-skip
Skip notification from the automated backport with mergify
labels
Mar 2, 2022
belimawr
approved these changes
Mar 2, 2022
mergify bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
(cherry picked from commit 4fabfb1)
mergify bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
(cherry picked from commit 4fabfb1)
mergify bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
(cherry picked from commit 4fabfb1)
kvch
added a commit
that referenced
this pull request
Mar 3, 2022
kvch
added a commit
that referenced
this pull request
Mar 3, 2022
kvch
added a commit
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-7.17
Automated backport to the 7.17 branch with mergify
backport-v8.0.0
Automated backport with mergify
backport-v8.1.0
Automated backport with mergify
bug
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds missing
defer
keywords so mutexes only after the real critical section.The problem was reported by golangci linter we use in https://github.com/elastic/elastic-agent-libs.
Why is it important?
Previously in the monitoring registry implementation two mutexes were unlocked right after locking. So the data structures they were supposed to protect were still subject to concurrent access.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.