Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of metricbeat process-gathering metrics and system/process #30076

Merged
merged 46 commits into from
Feb 14, 2022
Merged

Refactor of metricbeat process-gathering metrics and system/process #30076

Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
b4d6724
start work on process refactoring
fearful-symmetry Nov 15, 2021
3c3e6b0
finish new pid fetcher
fearful-symmetry Nov 16, 2021
11acfe7
continue work on linux process metrics refactoring
fearful-symmetry Nov 30, 2021
2d846f5
continue work on linux implementation
fearful-symmetry Dec 1, 2021
057da2f
complete first draft of linux support
fearful-symmetry Jan 14, 2022
46ee831
Merge remote-tracking branch 'upstream/master' into system-process-ne…
fearful-symmetry Jan 14, 2022
ddecc2d
finish linux, start MacOS
fearful-symmetry Jan 20, 2022
49816b6
fix tests
fearful-symmetry Jan 20, 2022
765f5f4
fix darwin calls
fearful-symmetry Jan 20, 2022
f9e5dd6
finish first pass at darwin
fearful-symmetry Jan 24, 2022
784a7a9
add aix, start cleanup
fearful-symmetry Jan 26, 2022
d9f8771
add new benchmark
fearful-symmetry Jan 26, 2022
578babf
start cleanup, fix misc. config values
fearful-symmetry Jan 27, 2022
88b3858
fix darwin caching
fearful-symmetry Jan 27, 2022
1bb007e
format
fearful-symmetry Jan 27, 2022
7ca6436
clean up code, fix some tests
fearful-symmetry Jan 28, 2022
ebe1a9c
Merge remote-tracking branch 'upstream/master' into system-process-ne…
fearful-symmetry Jan 28, 2022
efcdc66
move over root event logic, fix a ton of little bugs
fearful-symmetry Jan 28, 2022
3a96cf7
fix tests, add default hostfs to init
fearful-symmetry Jan 28, 2022
c53f86e
fix cgroup field
fearful-symmetry Jan 31, 2022
8e8b1ac
try to fix process tests
fearful-symmetry Feb 1, 2022
aeb77f2
no idea, just trying to fix windows
fearful-symmetry Feb 1, 2022
ee56545
remove mb import from libbeat
fearful-symmetry Feb 1, 2022
789570c
blindly attempt to fix windows unit tests
fearful-symmetry Feb 1, 2022
ab10589
fix log typo
fearful-symmetry Feb 1, 2022
c51f113
skip broken windows tests, at least for now
fearful-symmetry Feb 2, 2022
41be095
code cleanup
fearful-symmetry Feb 2, 2022
1a63b58
fix windows process states
fearful-symmetry Feb 2, 2022
1f07cae
yet another attempt at fixing windows tests
fearful-symmetry Feb 3, 2022
4bd598a
continued attempts at making windows tests less flaky
fearful-symmetry Feb 3, 2022
de6e3ea
Merge remote-tracking branch 'upstream/main' into system-process-new-…
fearful-symmetry Feb 3, 2022
9d968eb
try to fix formatting
fearful-symmetry Feb 3, 2022
712acb2
give up, disable flaky windows tests
fearful-symmetry Feb 4, 2022
0dcf56a
Merge remote-tracking branch 'upstream/main' into system-process-new-…
fearful-symmetry Feb 7, 2022
f98d3c2
remove old code
fearful-symmetry Feb 7, 2022
ffac2a9
another shot at playing with windows tests
fearful-symmetry Feb 8, 2022
aa69465
clean up now-working tests
fearful-symmetry Feb 8, 2022
b542e35
Merge remote-tracking branch 'upstream/main' into system-process-new-…
fearful-symmetry Feb 9, 2022
8e73a09
Merge remote-tracking branch 'upstream/main' into system-process-new-…
fearful-symmetry Feb 9, 2022
2f1b1ed
Merge remote-tracking branch 'upstream/main' into system-process-new-…
fearful-symmetry Feb 9, 2022
85c99f1
Merge remote-tracking branch 'upstream/main' into system-process-new-…
fearful-symmetry Feb 10, 2022
09051eb
try to give python unit tests a little more room
fearful-symmetry Feb 10, 2022
2857e08
fix conditionals in tests
fearful-symmetry Feb 10, 2022
45859c4
try to tune python tests a little
fearful-symmetry Feb 10, 2022
96b8917
just rewrite test
fearful-symmetry Feb 11, 2022
4cbce53
Merge remote-tracking branch 'upstream/main' into system-process-new-…
fearful-symmetry Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix log typo
  • Loading branch information
@fearful-symmetry
fearful-symmetry committed Feb 1, 2022
commit ab105897aa0dd389b77d1dbb55a878d7e7d7bdad
2 changes: 1 addition & 1 deletion libbeat/metric/system/process/process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ func (procStats *Stats) pidIter(pid int, procMap map[int]ProcState, proclist []P
return procMap, proclist
}
if !saved {
procStats.logger.Debugf("Process name does not matches the provided regex; PID=%d; name=%s", pid, status.Name)
procStats.logger.Debugf("Process name does not match the provided regex; PID=%d; name=%s", pid, status.Name)
return procMap, proclist
}
procMap[pid] = status
Expand Down