Add fields local to processor #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the fields definition local to each processor makes it more modular and extendable. Further changes * Introduce `make collect` in each beat. Now only `make collect` has to be called for all beats. * Move processor to its own namespace
andrewkroh
approved these changes
Nov 1, 2016
|
jenkins, test it |
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Nov 2, 2016
This should simplify the extension of packetbeat with further protocols and make it more modular. This change requires elastic#2897
urso
pushed a commit
that referenced
this pull request
Nov 3, 2016
This should simplify the extension of packetbeat with further protocols and make it more modular. This change requires #2897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the fields definition local to each processor makes it more modular and extendable.
Further changes
make collectin each beat. Now onlymake collecthas to be called for all beats.