Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow conditional processing in decode_xml #27159

Merged
merged 3 commits into from
Aug 2, 2021
Merged

Allow conditional processing in decode_xml #27159

merged 3 commits into from
Aug 2, 2021

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Jul 30, 2021

What does this PR do?

This PR allows when in the accepted fields of decode_xml.

Why is it important?

Without this conditionals are not allowed when using decode_xml.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 30, 2021
@kvch kvch requested review from andrewkroh and marc-gr July 30, 2021 15:48
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 30, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-02T09:43:11.013+0000

  • Duration: 132 min 26 sec

  • Commit: adb827d

Test stats 🧪

Test Results
Failed 0
Passed 49393
Skipped 5318
Total 54711

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 49393
Skipped 5318
Total 54711

@kvch kvch changed the title Allow conditional processing in decode_xml Allow conditional processing to decode_xml Aug 2, 2021
@kvch kvch added backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team labels Aug 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 2, 2021
@kvch kvch added the bug label Aug 2, 2021
@kvch kvch changed the title Allow conditional processing to decode_xml Allow conditional processing in decode_xml Aug 2, 2021
@kvch kvch merged commit a32aa86 into elastic:master Aug 2, 2021
mergify bot pushed a commit that referenced this pull request Aug 2, 2021
@kvch
Allow conditional processing in decode_xml and `decode_xml_winlogev…
7cd693c 
…ent` (#27159)

(cherry picked from commit a32aa86)
@mergify mergify bot mentioned this pull request Aug 2, 2021
Merged
mergify bot pushed a commit that referenced this pull request Aug 2, 2021
@kvch
Allow conditional processing in decode_xml and `decode_xml_winlogev…
72fcbb0 
…ent` (#27159)

(cherry picked from commit a32aa86)
@mergify mergify bot mentioned this pull request Aug 2, 2021
Merged
kvch added a commit that referenced this pull request Aug 2, 2021
@mergify @kvch
Allow conditional processing in decode_xml and `decode_xml_winlogev…
bfbf7f6 
…ent` (#27159) (#27188)

(cherry picked from commit a32aa86)

Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
kvch added a commit that referenced this pull request Aug 3, 2021
@mergify @kvch
Allow conditional processing in decode_xml and `decode_xml_winlogev…
4a58077 
…ent` (#27159) (#27189)

(cherry picked from commit a32aa86)

Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify bug Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kvch @elasticmachine @andrewkroh @marc-gr