[elastic-agent] Add hint to version command for binary #25380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default when running `elastic-agent version` it is expected that the daemon is running. If it is not running, an error is shown. Then the flag --binary-only should be used. A hint for this is added here to the error message for users.
ruflin
added
Team:Elastic-Agent
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
blakerouse
reviewed
Apr 28, 2021
| @@ -64,7 +64,7 @@ func NewCommandWithArgs(streams *cli.IOStreams) *cobra.Command { | |||
| binaryOnly, _ := cmd.Flags().GetBool("binary-only") | |||
| if !binaryOnly { | |||
| if d, err := queryDaemon(); err != nil { | |||
| returnErr = fmt.Errorf("failed to communicate with running daemon: %w", err) | |||
| returnErr = fmt.Errorf("could not get version. failed to communicate with running daemon: %w\n Use --binary-only flag to get version from binary.", err) | |||
There was a problem hiding this comment.
I would update that to so
Use --binary-only flag to skip trying to retrieve version from running daemon.
blakerouse
approved these changes
Apr 28, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
By default when running `elastic-agent version` it is expected that the daemon is running. If it is not running, an error is shown. Then the flag --binary-only should be used. A hint for this is added here to the error message for users. (cherry picked from commit 7916ad4)
ruflin
added a commit
that referenced
this pull request
Apr 28, 2021
By default when running `elastic-agent version` it is expected that the daemon is running. If it is not running, an error is shown. Then the flag --binary-only should be used. A hint for this is added here to the error message for users. (cherry picked from commit 7916ad4) Co-authored-by: Nicolas Ruflin <spam@ruflin.com>
|
We have validated this feature in lieu of github.com//issues/20825 ticket on 8.0 BC1 and 8.0 snapshot build and found it working fine there. Screenshots: Further, we will validate same on 8.1 too once stable build BC2 will be available. Thanks |
|
Hi @jlind23 We have revalidated it on 8.1 snapshot build and found it working fine there too. Screenshot: Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default when running
elastic-agent versionit is expected that the daemon is running. If it is not running, an error is shown. Then the flag --binary-only should be used. A hint for this is added here to the error message for users.