Improve healthcheck in consul docker image #24663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime fields are not reported till some seconds after startup in Consul 1.9. If tests are fast enough, they will get event without these expected fields, and will fail. Change the healthcheck to ensure that these fields are being reported.
jsoriano
added
module
review
Metricbeat
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
/test |
ChrsMark
approved these changes
Mar 22, 2021
|
Closes #24603 |
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Mar 22, 2021
Runtime fields are not reported till some seconds after startup in Consul 1.9. If tests are fast enough, they will get event without these expected fields, and will fail. Change the healthcheck to ensure that these fields are being reported. (cherry picked from commit 307104c)
jsoriano
added a commit
that referenced
this pull request
Mar 22, 2021
Runtime fields are not reported till some seconds after startup in Consul 1.9. If tests are fast enough, they will get event without these expected fields, and will fail. Change the healthcheck to ensure that these fields are being reported. (cherry picked from commit 307104c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky test in Metricbeat Consul module.
Runtime fields are not reported till some seconds after startup in
Consul 1.9. If tests are fast enough, they will get events without
these expected fields, and will fail. Change the healthcheck to
ensure that these fields are being reported.
Tests with Consul 1.9 were introduced in #24123.
Closes #24589.