Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][static][workers] write access to allow deleteDir #24233

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 25, 2021

What does this PR do?

The beats build system somehow create files with read only access and different ownership, this causes issues in the CI when using static workers

Why is it important?

Ensure the static workers can be tear down correctly.

image

jenkins@worker-0a434dec4bdcd060f:~/workspace/Beats_beats_PR-22662/pkg/mod$ ls -l sigs.k8s.io/structured-merge-diff/v4@v4.0.1/schema/
total 36
-r--r--r-- 1 jenkins jenkins 1178 Feb 24 22:59 doc.go
-r--r--r-- 1 jenkins jenkins 9898 Feb 24 22:59 elements.go
-r--r--r-- 1 jenkins jenkins 3369 Feb 24 22:59 elements_test.go
-r--r--r-- 1 jenkins jenkins 4291 Feb 24 22:59 equals.go
-r--r--r-- 1 jenkins jenkins 3663 Feb 24 22:59 equals_test.go
-r--r--r-- 1 jenkins jenkins 3121 Feb 24 22:59 schemaschema.go
jenkins@worker-0a434dec4bdcd060f:~/workspace/Beats_beats_PR-22662/pkg/mod$ ls -l sigs.k8s.io/structured-merge-diff/v4@v4.0.1/schema/elements_test.go 
-r--r--r-- 1 jenkins jenkins 3369 Feb 24 22:59 sigs.k8s.io/structured-merge-diff/v4@v4.0.1/schema/elements_test.go

Test

image

@v1v v1v added automation Team:Automation Label for the Observability productivity team labels Feb 25, 2021
@v1v v1v requested a review from a team February 25, 2021 10:30
@v1v v1v self-assigned this Feb 25, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 25, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 25, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24233 updated

  • Start Time: 2021-02-25T10:59:16.956+0000

  • Duration: 12 min 1 sec

  • Commit: 0139e52

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

Comment on lines 18 to 19
# Change permissions with write access of all files inside the specific folder
docker run -v "${LOCATION}":/beat ${DOCKER_IMAGE} sh -c "find /beat -exec chmod -R +w {} \;"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command is somehow too expensive, it added 4 minutes

image

Comment on lines +18 to +19
# Change permissions with write access of all files inside the specific folder
chmod -R +w "${LOCATION}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is faster now

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants