Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #23959 to 7.x: Remove unused reviewdog dependency #23963

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Cherry-pick #23959 to 7.x: Remove unused reviewdog dependency #23963

merged 1 commit into from
Feb 10, 2021

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Feb 10, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #23959 to 7.x branch. Original message:

Reviewdog was used a long time ago, but we still list it as a dependency. Not anymore.

@kvch kvch added [zube]: In Review backport Team:Automation Label for the Observability productivity team labels Feb 10, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 10, 2021
michalpristas
michalpristas approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport looks ok

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23963 opened

  • Start Time: 2021-02-10T14:26:52.304+0000

  • Duration: 150 min 41 sec

  • Commit: 2b59925

Test stats 🧪

Test Results
Failed 0
Passed 45703
Skipped 4799
Total 50502

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 45703
Skipped 4799
Total 50502

@kvch kvch merged commit 347b179 into elastic:7.x Feb 10, 2021
@zube zube bot removed the [zube]: Done label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

Assignees
No one assigned
Labels
backport Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvch @elasticmachine @michalpristas