Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23438 to 7.x: Upgrade redis client #23497

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jan 14, 2021

Cherry-pick of PR #23438 to 7.x branch. Original message:

What does this PR do?

This PR updates redis client library used by Metribceat module , redis output and redis filebeat input.

Why is it important?

So as to support URLs and TLS settings.

How to test this PR locally

Test Metricbeat Redis module

  1. run a redis target service running docker-compose up inside module/redis directory
  2. enable redis module and set the proper host ie 0.0.0.0:32837 (run docker ps to find the exposed port in your case)
  3. Exec inside redis container and run redis-cli to populate keys: SET mykey "Hello"
  4. Start metricbeat and verify that metrics are being collected

Test Filebeat Redis slowlog fileset

  1. Enable redis slowlog with the proper host and start Filebeat.
  2. Execute again inside the redis container and create some keys. Then feed slowlog with CONFIG SET slowlog-log-slower-than 5 and keys *.
  3. Verify that metrics are being collected.

Test redis output

  1. Define redis output for metribceat ie (set the proper host):
output.redis:
  hosts: ["0.0.0.0:32837"]
  key: "metricbeat"
  db: 0
  timeout: 5
  1. Metricbeat module to collect some metrics
  2. Using redis-cli verify that metrics are sent to Redis with lrange metricbeat 0 1

Test Filebeat redis input

  1. Enable redis input
filebeat.inputs:
- type: redis
  hosts: ["0.0.0.0:32837"]
  1. Start Filebeat
  2. Execute again inside the redis container and create some keys. Then feed slowlog with CONFIG SET slowlog-log-slower-than 5 and keys *.
  3. Verify that metrics are being collected.

Related issues

#16522
elastic/integrations#361

(cherry picked from commit 68a5daa)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 14, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23497 opened

    • Start Time: 2021-01-14T08:45:22.021+0000
  • Duration: 99 min 24 sec

  • Commit: c57dbd6

Test stats 🧪

Test Results
Failed 0
Passed 16790
Skipped 1248
Total 18038

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16790
Skipped 1248
Total 18038

@ChrsMark ChrsMark merged commit 9aab0ac into elastic:7.x Jan 14, 2021
@zube zube bot removed the [zube]: Done label Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants