Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #23313 to 7.10: Ensure mage is installed to the expected version #23318

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Cherry-pick #23313 to 7.10: Ensure mage is installed to the expected version #23318

merged 1 commit into from
Dec 29, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Dec 29, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #23313 to 7.10 branch. Original message:

What does this PR do?

Ensure mage is installed to the expected version in makefile target.

Why is it important?

Fix linting in master branch.

Mage 0.11 has been released and installation using the make target is not specifying a version, which changes go mod files, breaking linting.

@jsoriano jsoriano added [zube]: In Review backport Team:Automation Label for the Observability productivity team Team:Integrations Label for the Integrations team labels Dec 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 29, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23318 opened

  • Start Time: 2020-12-29T15:46:59.683+0000

  • Duration: 55 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 16597
Skipped 1385
Total 17982

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 14 sec . View more details on here
  • Description: terraform apply -auto-approve
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
  • Description: terraform apply -auto-approve

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16597
Skipped 1385
Total 17982

ycombinator
ycombinator approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM.

@jsoriano jsoriano merged commit 41c5f9d into elastic:7.10 Dec 29, 2020
@jsoriano jsoriano deleted the backport_23313_7.10 branch December 29, 2020 20:45
@zube zube bot removed the [zube]: Done label Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees
No one assigned
Labels
backport Team:Automation Label for the Observability productivity team Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @elasticmachine @ycombinator