Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22605 to 7.x: Add support for customized monitoring API #23279

Merged
merged 2 commits into from
Dec 30, 2020

Conversation

urso
Copy link

@urso urso commented Dec 24, 2020

Cherry-pick of PR #22605 to 7.x branch. Original message:

What does this PR do?

allow customized monitoring api to be added

Why is it important?

allow customized monitoring api to be added

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

N/A

How to test this PR locally

N/A

Use cases

Leverage beats' http server, same port to be used, to expose any other info that user likes to do in a beat implementation or customization.

@urso urso added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Dec 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 24, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 24, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23279 updated

  • Start Time: 2020-12-24T13:24:04.870+0000

  • Duration: 50 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 17462
Skipped 1408
Total 18870

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
  • Description: terraform apply -auto-approve
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
  • Description: terraform apply -auto-approve

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17462
Skipped 1408
Total 18870

@botelastic
Copy link

botelastic bot commented Dec 24, 2020

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM.

@urso urso merged commit c04dd7f into elastic:7.x Dec 30, 2020
@urso urso deleted the backport_22605_7.x branch December 30, 2020 14:50
@zube zube bot removed the [zube]: Done label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants