[Filebeat] Add fortinet/firewall network direction override based on interface #23072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewstucki
added
bug
enhancement
Filebeat
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
|
Since there's no way of overriding the config on a per golden file basis. Here's a diff to demonstrate this working: With the following configuration change diff --git a/x-pack/filebeat/module/fortinet/firewall/manifest.yml b/x-pack/filebeat/module/fortinet/firewall/manifest.yml
index f76743d96..8c2459c00 100644
--- a/x-pack/filebeat/module/fortinet/firewall/manifest.yml
+++ b/x-pack/filebeat/module/fortinet/firewall/manifest.yml
@@ -10,7 +10,9 @@ var:
- name: input
default: udp
- name: internal_interfaces
+ default: [ "wan1" ] # I want it backwards for effect
- name: external_interfaces
+ default: [ "LAN" ] # I want it backwards for effect
ingest_pipeline:
- ingest/pipeline.ymlWe see the following change: "log.offset": 2683,
"message": "Web.Client: HTTPS.BROWSER,",
"network.application": "HTTPS.BROWSER",
- "network.direction": "outbound",
+ "network.direction": "inbound",
"network.iana_number": "6",
"network.protocol": "ssl",
"observer.egress.interface.name": "wan1", |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
leehinman
approved these changes
Dec 10, 2020
andrewstucki
pushed a commit
to andrewstucki/beats
that referenced
this pull request
Dec 10, 2020
…interface (elastic#23072) * [Filebeat] Add fortinet/firewall network direction override based on interface * Add changelog entry * Don't override categorization if no interface name is set (cherry picked from commit 5a03647)
6 tasks
andrewstucki
pushed a commit
that referenced
this pull request
Dec 11, 2020
…irection override based on interface (#23085) * [Filebeat] Add fortinet/firewall network direction override based on interface (#23072) * [Filebeat] Add fortinet/firewall network direction override based on interface * Add changelog entry * Don't override categorization if no interface name is set (cherry picked from commit 5a03647) * Fix up changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is pretty similar to the other PRs that allow override based off zone, such as #23066. However, since fortinet doesn't ship zone information, this uses the interface instead.
Additionally, I found some values in the utm source that were setting network.direction to "outgoing"/"incoming", so I normalized those.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues