Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat][Sophos] Docs YAML example for serial number mapping fixes #21004

Merged
merged 1 commit into from
Sep 7, 2020
Merged

[Filebeat][Sophos] Docs YAML example for serial number mapping fixes #21004

merged 1 commit into from
Sep 7, 2020

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Sep 7, 2020 •
edited
Loading

What does this PR do?

The example config and documentation on serial number mapping was in the wrong format, causing confusion

Why is it important?

Give correct default values to users that utilizes the module

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 7, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 7, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Marc Guasch, Replayed #1]

  • Start Time: 2020-09-07T10:47:17.859+0000

  • Duration: 53 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 5583
Skipped 825
Total 6408

@P1llus
Copy link
Member Author

P1llus commented Sep 7, 2020

jenkins test this please

@marc-gr marc-gr merged commit 6aa800c into elastic:master Sep 7, 2020
marc-gr pushed a commit to marc-gr/beats that referenced this pull request Sep 7, 2020
@P1llus @marc-gr
Updating an error in config yml format of the docs for Sophos module (e…
23b15df 
…lastic#21004)

(cherry picked from commit 6aa800c)
@marc-gr marc-gr mentioned this pull request Sep 7, 2020
Merged
4 tasks
@marc-gr marc-gr added the v7.10.0 label Sep 7, 2020
marc-gr added a commit that referenced this pull request Sep 8, 2020
@marc-gr @P1llus
Updating an error in config yml format of the docs for Sophos module (#…
a6eafc8 
…21004) (#21009)

(cherry picked from commit 6aa800c)

Co-authored-by: Marius Iversen <pillus@chasenet.org>
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@P1llus @melchiormoulin
Updating an error in config yml format of the docs for Sophos module (e…
3ccee04 
…lastic#21004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees
No one assigned
Labels
enhancement Filebeat Filebeat v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P1llus @elasticmachine @marc-gr