Refactor processors and readers #2088
Conversation
ruflin
added
in progress
|
@urso We are currently using a mix of reader and processor. I see processor as a superset of reader, means I plan to rename all readers to processors and group them in one package. Any thoughts? |
|
+1 for consistent naming. At some point I intended to all 'LineReader's to be a processor. On the other, we already got processors (generic?) in libbeat. |
|
Alternatively we could rename everything to a reader? Looking at the readers / processors we have, reader would also be accurate I think. |
|
I think I'd prefer Reader here, to not get confused with libbeat processors. |
|
Agree. I will migrate everything to reader. How should be call the struct? |
ruflin
force-pushed
the
reader-cleanup
branch
2 times, most recently
from
7e4ab8f to
ecc3726
Compare
ruflin
added
review
and removed
in progress
|
|
||
| // Encode reader produces lines by reading lines from an io.Reader | ||
| // through a decoder converting the reader it's encoding to utf-8. | ||
| type Encode struct { |
There was a problem hiding this comment.
hm... I think we should name the Decode, Conver or Transform. This reader converts input encoding into utf8
There was a problem hiding this comment.
I think Encode is still correct, but we could name it EncodeUTF8 to make it more clear?
There was a problem hiding this comment.
nah, rather use Encode or Encoding then EncodeUTF8
There was a problem hiding this comment.
Ah right, we pass the codec, so it could be anything not only uft-8 if configured differently. In this case I would stick with reader.Encode?
There was a problem hiding this comment.
We can still renamed it in combination with #2089 if something else becomes obvious.
* Rename all processors to readers * Rename line struct to Message * Remove "reader" from all structs inside reader package No logic changes are done in this change.
|
@urso requested changes pushed. |
|
LGTM. waiting for travis. |
I realized that when rebasing elastic#2091 on top of elastic#2088 a JSON test was lost. This resurrects it.
No logic changes are done in this change.