Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard for Network #2071

Merged
merged 6 commits into from
Jul 21, 2016
Merged

Conversation

monicasarbu
Copy link
Contributor

@monicasarbu monicasarbu commented Jul 20, 2016

This PR create a dedicated Kibana dashboard for the System Network data.

@ruflin
Copy link
Collaborator

ruflin commented Jul 20, 2016

Would it be possible that we add a screenshot to the docs for each dashboard we have? That will make it very easy visible for users to see what they get and makes our docs more beautiful. Disadvantage is that we must keep the screenshots up-to-date ...

@ruflin
Copy link
Collaborator

ruflin commented Jul 20, 2016

All dashboards must be added under the specific module in _meta/kibana. Otherwise when you run make collect it will overwrite all your dashboards. It should be as easy as just copy the files over.

@monicasarbu
Copy link
Contributor Author

Yes, I am planning to add screenshots of the dashboards later after I finish creating a dashboard for each Metricbeat module. I hope to write docs about how to use the dashboards.

@monicasarbu
Copy link
Contributor Author

After internal discussions, we decided to create dashboards per Metricbeat module and not per entire Metricbeat and have the navigation bar only for the system module. You can access the dashboards of the other Metricbeat modules by clicking onOpen in Kibana.

@@ -25,6 +25,7 @@ import (
_ "github.com/elastic/beats/metricbeat/module/system/diskio"
_ "github.com/elastic/beats/metricbeat/module/system/filesystem"
_ "github.com/elastic/beats/metricbeat/module/system/fsstat"
_ "github.com/elastic/beats/metricbeat/module/system/load"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this changed? switch forth / back between branches? make collect should clean it up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how it ended there. I removed it manually.

Copy link
Contributor Author

@monicasarbu monicasarbu Jul 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. make collect added it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monicasarbu Probably the empty directories for load still exists from your other branch ;-)

@tsg tsg merged commit a77e88f into elastic:master Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants