Cherry-pick #19815 to 7.x: Move http_endpoint input to v2 input API #19891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
[zube]: In Review
backport
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
needs_team
kvch
reviewed
Jul 14, 2020
| @@ -193,7 +184,7 @@ def test_http_endpoint_get_request(self): | |||
| payload = {self.prefix: message} | |||
| headers = {"Content-Type": "application/json", "Accept": "application/json"} | |||
| r = requests.get(self.url, headers=headers, data=json.dumps(payload)) | |||
|
|
|||
| print("response:", r.status_code, r.text) | |||
There was a problem hiding this comment.
I assume this is just a debug print which does not belong here. Do you mind removing it from master as well?
There was a problem hiding this comment.
it belongs here. nosetest supresses output by default, but if the test fails (or if you enable verbose mode) then everything you printed will be displayed in the context of the test. The 'log' is here to give you a hint why the assert did fail. using assert in python tests just tells you where it did fail, not why.
kvch
approved these changes
Jul 14, 2020
(cherry picked from commit 542a4af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19815 to 7.x branch. Original message:
What does this PR do?
Update the http_endpoint input to be based on the v2 input API.
This change unexports most symbols and splits the HttpEndpoint into a httpEndpoint (config handling and server run), httpHandler, and a validator type.
The server used to set up a timeout of 10s, based on the period of the Run method gets called. With the v2 API the Run method must block until shutdown or on fatal error. We keep the server alive now.
The json object parsing is local to the handler method only now and not stored in the HTTPEndpoint anymore. This fixes a potential bug with events not getting published or duplicated if multiple clients are served concurrently.
The config validation for the authentication configuration was done in the validation step. This has been moved to
config.Validateto stop the initialization process early if an invalid configuration has been provided.Note: I mostly moved code around. The input still needs more attention (in follow up PRs) regarding testing, and code documentation. All in all the changes should not be user visible.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
configure the http_endpoint input and send JSON objects via curl. The objects should be visible in the beats output.
Related issues