-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Unroll on unauthorised #19722
Merged
michalpristas
merged 16 commits into
elastic:master
from
michalpristas:agent-unenroll-on-auth
Jul 14, 2020
Merged
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
099b031
unenroll on not authorised
michalpristas 0aedb75
cleanup
michalpristas 0fcda43
tidy
michalpristas f4b496d
test
michalpristas 043d052
tidy
michalpristas a3238d8
Merge branch 'master' of github.com:elastic/beats into agent-unenroll…
michalpristas 2d18115
errors udpdate
michalpristas 396e123
Merge branch 'master' of github.com:elastic/beats into agent-unenroll…
michalpristas 2cbde50
fmt
michalpristas bb99a0e
readability nit
michalpristas 1d4d02c
Merge branch 'master' of github.com:elastic/beats into agent-unenroll…
michalpristas 993cbbc
Merge branch 'master' of github.com:elastic/beats into agent-unenroll…
michalpristas bc15e20
notice
michalpristas fd4d68d
Merge branch 'master' of github.com:elastic/beats into agent-unenroll…
michalpristas 5445dd8
Merge branch 'master' of github.com:elastic/beats into agent-unenroll…
michalpristas 1e86314
Merge branch 'master' of github.com:elastic/beats into agent-unenroll…
michalpristas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not possible to unwrap the error and check for the specific error type?
Would prefer that over string matching.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i spent some time trying to achieve that but with no luck, took a different path today , fresh mind helped