Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #19539 to 7.8: Fix configuration values in the perfmon metricset #19666

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Cherry-pick #19539 to 7.8: Fix configuration values in the perfmon metricset #19666

merged 1 commit into from
Jul 7, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Jul 6, 2020

Cherry-pick of PR #19539 to 7.8 branch. Original message:

What does this PR do?

Fixes the counter paths in the configuration example , perfmon metricset.

Why is it important?

A working default example.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@narph
Fix configuration values in the perfmon metricset (elastic#19539)
21ef4c7 
* fix config

* changelog

(cherry picked from commit 8ebcc0d)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 6, 2020
@narph narph self-assigned this Jul 6, 2020
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Jul 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 6, 2020
@zube zube bot added [zube]: Inbox needs_team Indicates that the issue/PR needs a Team:* label [zube]: In Review and removed [zube]: In Review [zube]: Inbox needs_team Indicates that the issue/PR needs a Team:* label labels Jul 6, 2020
@botelastic
Copy link

botelastic bot commented Jul 6, 2020

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19666 opened]

  • Start Time: 2020-07-06T09:59:16.124+0000

  • Duration: 78 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 3144
Skipped 700
Total 3844

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-06T10:32:08.891+0000

    • log

kaiyan-sheng
kaiyan-sheng approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@narph narph merged commit c310620 into elastic:7.8 Jul 7, 2020
@narph narph deleted the backport_19539_7.8 branch July 7, 2020 09:36
@narph narph mentioned this pull request Aug 5, 2020
Closed
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@narph
Fix configuration values in the perfmon metricset (elastic#19539) (el…
84623e9 
…astic#19666)

* fix config

* changelog

(cherry picked from commit 312df9a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@narph narph

Labels
backport Team:Integrations Label for the Integrations team [zube]: Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @kaiyan-sheng