Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18890 to 7.8: Add check on <no value> config option value for the azure input resource_manager_endpoint #19351

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Jun 24, 2020

Cherry-pick of PR #18890 to 7.8 branch. Original message:

What does this PR do?

Adds a check on <no value> config option value for the azure input resource_manager_endpoint
Updates test.

Why is it important?

Seems that after some recent changes, if a value is not set for resource_manager_endpoint then the value <no value> is sent to the input config. This needs to be checked at the input level.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Do not set a value for resource_manager_endpoint when running the azure module in filebeat, no events will be generated and logs will provide more information on the error regarding the azure env.

…source_manager_endpoint` (elastic#18890)

* change

* update changelog

(cherry picked from commit 8dda6e1)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2020
@narph narph self-assigned this Jun 24, 2020
@narph narph added [zube]: In Review Team:Integrations Label for the Integrations team labels Jun 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 24, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19351 updated]

  • Start Time: 2020-06-24T08:13:11.118+0000

  • Duration: 44 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 2186
Skipped 382
Total 2568

@narph narph merged commit fb088c8 into elastic:7.8 Jun 25, 2020
@narph narph deleted the backport_18890_7.8 branch June 25, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants