-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix winlogbeat powershell event processing. #18966
Merged
marc-gr
merged 2 commits into
elastic:master
from
marc-gr:fix_winlogbeat_powershell-downgrade
Jun 5, 2020
Merged
Fix winlogbeat powershell event processing. #18966
marc-gr
merged 2 commits into
elastic:master
from
marc-gr:fix_winlogbeat_powershell-downgrade
Jun 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jun 4, 2020
marc-gr
force-pushed
the
fix_winlogbeat_powershell-downgrade
branch
from
June 4, 2020 10:34
98a056e
to
a151a0b
Compare
leehinman
reviewed
Jun 4, 2020
x-pack/winlogbeat/module/powershell/config/winlogbeat-powershell.js
Outdated
Show resolved
Hide resolved
Fix event processing for different engine versions. Improve powershell dashboard
marc-gr
force-pushed
the
fix_winlogbeat_powershell-downgrade
branch
from
June 4, 2020 15:22
a151a0b
to
a953747
Compare
leehinman
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Jun 5, 2020
Fix winlogbeat powershell event processing. - Fix event processing for different engine versions. - Improve powershell dashboard (cherry picked from commit d5fee98)
4 tasks
marc-gr
added a commit
that referenced
this pull request
Jun 5, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Fix winlogbeat powershell event processing. - Fix event processing for different engine versions. - Improve powershell dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a function to dynamically calculate the number of chunks the dissect needs to parse for Powershell events.
It also improves the provided dashboard to show more information on the detail area.
Why is it important?
Powershell events carry a fixed amount of parameters. Seems to be that for downgraded events the number of parameters varies, so dissect failed for those.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Screenshots
The updated dashboard