-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build packages in parallel #17723
Merged
kuisathaverat
merged 22 commits into
elastic:master
from
kuisathaverat:parallel-package
Apr 17, 2020
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
2a47768
feat: build packages in parallel
kuisathaverat 866f166
fix: unstable on a stage ignored
kuisathaverat eb1a613
fix: unstable on a stage ignored
kuisathaverat 2dd22e9
fix: make beats in parallel by architecture
kuisathaverat 009ae72
fix: use correct PLATFORMS format
kuisathaverat ab7f6c6
fix: synstax error
kuisathaverat 733080e
fix: method code too large! again
kuisathaverat 1345540
fix: use error step
kuisathaverat d29bbca
fix: add goos method
kuisathaverat 4727387
fix: use only one axis
kuisathaverat a9c9863
fix: path for scripts
kuisathaverat d9902b7
fix: store artifects
kuisathaverat d6cd7a6
fix: add linux platforms
kuisathaverat f75bd82
test: use checkout always
kuisathaverat efab4c4
fix: search for packages also on the root build folder
kuisathaverat e6b1617
fix: PLATFORMS variable
kuisathaverat 67ac9c5
fix: remove defaults
kuisathaverat 3aca138
feta: push docker images for the CI use
kuisathaverat f8995aa
fix: typo
kuisathaverat adfa160
fix: script worng
kuisathaverat f122b1f
fix: the other way around
kuisathaverat 8f54245
list Docker images
kuisathaverat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm missing something, but don't we build windows packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not from the betas-ci, we only have this jobs https://beats-ci.elastic.co/job/elastic+beats+master+package/
I've check https://github.com/elastic/beats/blob/master/dev-tools/mage/platforms.go#L29-L70 and there is a bunch of platforms we do not build on the beats-ci, Should we build them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checking the logs, I think does no matter what you put on PLATFORMS env var you always build all the packages
This is a log where PLATFORMS is
+linux/s390x
https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/pipelines/packaging/branches/PR-17723/runs/1/nodes/155/log/?start=0
but after build all the cross-compile Docker images I think it is compiling packages that are not requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, checking the output of one of the old jobs, the PLATFORMS env var it is ignored always build all the packages
https://beats-ci.elastic.co/job/elastic+beats+7.x+multijob-package-linux/125/console