[libbeat] Clarify field name / remove redundant semaphore creation #17622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
approved these changes
Apr 9, 2020
faec
added a commit
to faec/beats
that referenced
this pull request
Apr 9, 2020
…lastic#17622) (cherry picked from commit bf3eb4c)
syepes
pushed a commit
to syepes/beats
that referenced
this pull request
Apr 9, 2020
faec
added a commit
that referenced
this pull request
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename
queue.BufferConfig.Eventstoqueue.BufferConfig.MaxEventsto clarify its meaning, and remove a redundant check of it inpipeline.gothat created the semaphorePipeline.eventSematwice.This PR has no user-visible effects.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.