Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #17268 to 7.x: Update documentation for system.process.memory fields to include clarification on Windows memory terminology #17287

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Cherry-pick #17268 to 7.x: Update documentation for system.process.memory fields to include clarification on Windows memory terminology #17287

merged 1 commit into from
Mar 27, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Mar 27, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #17268 to 7.x branch. Original message:

What does this PR do?

Updates the description of the system/process memory fields.

Why is it important?

Related to #8345
Windows users are confused about the values reflected in the system.process.memory.rss.bytes and system.process.memory.size since the description and naming are not clear enough on the type of memory used/allocated etc.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@narph
Update documentation for system.process.memory fields to include clar…
33d94a2 
…ification on Windows memory terminology (elastic#17268)

* update field description

* update changelog

* fix naming

* update

(cherry picked from commit 66f23dc)
@narph narph self-assigned this Mar 27, 2020
@narph narph added backport Metricbeat Metricbeat [zube]: In Review Team:Integrations Label for the Integrations team labels Mar 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@zube zube bot removed the Team:Integrations Label for the Integrations team label Mar 27, 2020
@narph narph changed the title Cherry-pick #17268 to 7.x: Fix Disk Used and Disk Usage visualizations in the Metricbeat System dashboard Cherry-pick #17268 to 7.x: Update documentation for system.process.memory fields to include clarification on Windows memory terminology Mar 27, 2020
@narph narph added the Team:Integrations Label for the Integrations team label Mar 27, 2020
@narph narph merged commit 5c4af7c into elastic:7.x Mar 27, 2020
@narph narph deleted the backport_17268_7.x branch March 27, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@narph narph

Labels
backport Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@narph @elasticmachine @kaiyan-sheng @andresrc