Set version to 5.0.0-alpha3 #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be closer to what we plan for the unified release process, I'm setting the version in advance. The artifacts will be named 5.0.0-alpha3-SNAPSHOT during testing but the version in code is 5.0.0-alpha3. At the time of the release, we rename the artifacts to remove SNAPSHOT, without having to rebuild.
| @@ -1 +1,2 @@ | |||
| version: "5.0.0" | |||
|
|
|||
There was a problem hiding this comment.
Is there a reason for the empty line?
There was a problem hiding this comment.
No, it was generated like that by dev-tools/set_version. I fixed it now in the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be closer to what we plan for the unified release process, I'm setting the
version in advance. The artifacts will be named 5.0.0-alpha3-SNAPSHOT during
testing but the version in code is 5.0.0-alpha3. At the time of the release, we
rename the artifacts to remove SNAPSHOT, without having to rebuild.