Add more fixes from the review

elastic · dedemorton · Jun 18, 2020 · Mar 14, 2020 · May 7, 2020 · May 8, 2020
commit be2a844dec7b900015ee20cec2999a8d95528c0b
diff --git a/auditbeat/docs/getting-started.asciidoc b/auditbeat/docs/getting-started.asciidoc
@@ -97,9 +97,9 @@ visualizing your data. To load these assets:
 include::{libbeat-dir}/tab-widgets/setup-widget.asciidoc[]
 --
 +
-`-e` is optional and sends output to standard error instead of syslog.
+`-e` is optional and sends output to standard error instead of the configured log output.
 
-This step loads the recommended index template for writing to {es}
+This step loads the recommended {ref}/indices-templates.html[index template] for writing to {es}
 and deploys the sample dashboards for visualizing the data in {kib}.
 
 [TIP]
@@ -128,10 +128,6 @@ include::{libbeat-dir}/tab-widgets/start-widget.asciidoc[]
 If you see a warning about too many open files, you need to increase the
 `ulimit`. See the <<ulimit,FAQ>> for more details.
 
-//REVIEWERS: Removing cURL test because I think users will see a better view of
-//the data simply by going to the Discover app in Kibana. Showing the cURL
-//command is not ideal for cloud users.
-
 [float]
 [[view-data]]
 === Step 6: View your data in {kib}

diff --git a/filebeat/docs/filebeat-modules-options.asciidoc b/filebeat/docs/filebeat-modules-options.asciidoc
@@ -7,8 +7,6 @@
 <titleabbrev>Modules</titleabbrev>
 ++++
 
-// REVIEWERS: I've changed the focus of this topic to back to configuration.
-
 NOTE: Using {beatname_uc} modules is optional. You may decide to
 <<configuration-{beatname_lc}-options,configure inputs manually>> if you're using
 a log type that isn't supported, or you want to use a different setup.
@@ -53,10 +51,6 @@ along with any modules that are enabled in the configuration file or `modules.d`
 directory. If there's a conflict, the configuration specified at the command
 line is used.
 
-// REVIEWERS: I've removed the detail about using the --modules flag because
-// it seems like an extra detail. Users can look at the command reference to
-// learn how to specify the flag.
-
 [float]
 [[configure-modules-config-file]]
 === Configure modules in the +{beatname_lc}.yml+ file
@@ -85,9 +79,6 @@ The following example shows a configuration that runs the `nginx`,`mysql`, and
 - module: system
 ----
 
-// REVIEWERS: Deleting the section about configuring variable settings because
-// it doesn't really add much value to users who are looking at the module
-// config docs. It's just an extra hop.
 
 [[advanced-settings]]
 === Override input settings

diff --git a/filebeat/docs/getting-started.asciidoc b/filebeat/docs/getting-started.asciidoc
@@ -32,8 +32,6 @@ include::{libbeat-dir}/tab-widgets/spinup-stack-widget.asciidoc[]
 [[installation]]
 === Step 1: Install {beatname_uc}
 
-//REVIEWERS: We don't currently say anything about licensing here. Should we?
-
 Install {beatname_uc} on all the servers you want to monitor.
 
 To download and install {beatname_uc}, use the commands that work with your
@@ -61,9 +59,6 @@ include::{libbeat-dir}/shared/connecting-to-es.asciidoc[]
 [[enable-modules]]
 === Step 3: Enable and configure data collection modules
 
-// REVIEWERS: I'm intentionally focusing on the module config steps because I
-// feel it represents the fastest getting started experience. Any objections?
-
 {beatname_uc} uses modules to collect and parse log data.
 
 . Identify the modules you need to enable. To see a list of available
@@ -120,9 +115,9 @@ visualizing your data. To load these assets:
 include::{libbeat-dir}/tab-widgets/setup-widget.asciidoc[]
 --
 +
-`-e` is optional and sends output to standard error instead of syslog.
+`-e` is optional and sends output to standard error instead of the configured log output.
 
-This step loads the recommended index template for writing to {es}
+This step loads the recommended {ref}/indices-templates.html[index template] for writing to {es}
 and deploys the sample dashboards for visualizing the data in {kib}.
 
 This step does not load the ingest pipelines used to parse log lines. By

diff --git a/filebeat/docs/howto/load-ingest-pipelines.asciidoc b/filebeat/docs/howto/load-ingest-pipelines.asciidoc
@@ -1,8 +1,6 @@
 [[load-ingest-pipelines]]
 == Load ingest pipelines
 
-// REVIEWERS: This content originally lived in modules-getting-started.asciidoc
-
 The ingest pipelines used to parse log lines are set up automatically the first
 time you run {beatname_uc}, assuming the {es} output is enabled. If you're sending
 events to {ls}, or plan to use

@@ -13,9 +13,6 @@ your hosts. You'll learn how to:
 * send uptime data to {es}
 * visualize the uptime data in {kib}
 
-// REVIEWERS: This screenshot comes from demo.elastic.co. Let me know if you
-// have a build or screenshot that you'd prefer to use here. 
-
 [role="screenshot"]
 image::./images/heartbeat-statistics.png[{beatname_uc} HTTP monitoring dashboard]
 
@@ -56,7 +53,7 @@ include::{libbeat-dir}/tab-widgets/install-widget.asciidoc[]
 include::{libbeat-dir}/shared/connecting-to-es.asciidoc[]
 
 [float]
-[[condiguration]]
+[[configuration]]
 === Step 3: Configure Heartbeat monitors
 
 Heartbeat provides monitors to check the status of hosts at set intervals.
@@ -106,9 +103,9 @@ visualizing your data. To load these assets:
 include::{libbeat-dir}/tab-widgets/setup-widget.asciidoc[]
 --
 +
-`-e` is optional and sends output to standard error instead of syslog.
+`-e` is optional and sends output to standard error instead of the configured log output.
 
-The `setup` command loads the recommended index template for writing to {es}.
+This step loads the recommended {ref}/indices-templates.html[index template] for writing to {es}.
 It does not install {beatname_uc} dashboards.  Heartbeat dashboards and 
 installation steps are available in the
 https://github.com/elastic/uptime-contrib[uptime-contrib] GitHub repository.

diff --git a/journalbeat/docs/getting-started.asciidoc b/journalbeat/docs/getting-started.asciidoc
@@ -110,9 +110,9 @@ visualizing your data. To load these assets:
 include::{libbeat-dir}/tab-widgets/setup-linux-mac-win-widget.asciidoc[]
 --
 +
-`-e` is optional and sends output to standard error instead of syslog.
+`-e` is optional and sends output to standard error instead of the configured log output.
 
-This step loads the recommended index template for writing to {es}.
+This step loads the recommended {ref}/indices-templates.html[index template] for writing to {es}.
 
 [TIP]
 =====

@@ -54,6 +54,3 @@ endif::[]
 |Analyze security events
 |===
 --
-
-//REVIEWERS: We should decide which of the Beats shippers to highlight in this topic.
-//Right now, a few are missing from the list.
diff --git a/metricbeat/docs/getting-started.asciidoc b/metricbeat/docs/getting-started.asciidoc
@@ -114,9 +114,9 @@ visualizing your data. To load these assets:
 include::{libbeat-dir}/tab-widgets/setup-widget.asciidoc[]
 --
 +
-`-e` is optional and sends output to standard error instead of syslog.
+`-e` is optional and sends output to standard error instead of the configured log output.
 
-This step loads the recommended index template for writing to {es}
+This step loads the recommended {ref}/indices-templates.html[index template] for writing to {es}
 and deploys the sample dashboards for visualizing the data in {kib}.
 
 [TIP]

diff --git a/packetbeat/docs/getting-started.asciidoc b/packetbeat/docs/getting-started.asciidoc
@@ -166,9 +166,9 @@ visualizing your data. To load these assets:
 include::{libbeat-dir}/tab-widgets/setup-widget.asciidoc[]
 --
 +
-`-e` is optional and sends output to standard error instead of syslog.
+`-e` is optional and sends output to standard error instead of the configured log output.
 
-This step loads the recommended index template for writing to {es}
+This step loads the recommended {ref}/indices-templates.html[index template] for writing to {es}
 and deploys the sample dashboards for visualizing the data in {kib}.
 
 [TIP]

diff --git a/winlogbeat/docs/getting-started.asciidoc b/winlogbeat/docs/getting-started.asciidoc
@@ -101,8 +101,6 @@ logging.level: info
 PS C:\Program Files\Winlogbeat> .\winlogbeat.exe test config -c .\winlogbeat.yml -e
 ----
 
-//REVIEWERS: I've removed the logging section from the example shown above
-//because I don't think it's necessary and might confuse users. WDYT?
 
 For more information about configuring {beatname_uc}, also see:
 
@@ -129,7 +127,7 @@ visualizing your data. To load these assets:
 include::{libbeat-dir}/tab-widgets/setup.asciidoc[tag=win]
 --
 
-This step loads the recommended index template for writing to {es}
+This step loads the recommended {ref}/indices-templates.html[index template] for writing to {es}
 and deploys the sample dashboards for visualizing the data in {kib}.
 
 [TIP]

diff --git a/x-pack/functionbeat/docs/getting-started.asciidoc b/x-pack/functionbeat/docs/getting-started.asciidoc
@@ -122,9 +122,9 @@ visualizing your data. To load these assets:
 include::{libbeat-dir}/tab-widgets/setup-linux-mac-win-widget.asciidoc[]
 --
 +
-`-e` is optional and sends output to standard error instead of syslog.
+`-e` is optional and sends output to standard error instead of the configured log output.
 
-This step loads the recommended index template for writing to {es}.
+This step loads the recommended {ref}/indices-templates.html[index template] for writing to {es}.
 
 [TIP]
 =====