-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Enhancement)Add redis stream output #16716
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
Signed the contributor agree ment |
Hi @maguec 🙂 Thank you for contributing to this. I guess this is a WIP PR. You have fill all the fields in the title, including |
@sayden Local test case and better documentation of the change has been updated |
You need to add proper integration testing, like the ones here https://github.com/elastic/beats/blob/master/libbeat/outputs/redis/redis_integration_test.go Also, this change is fundamentally bigger than it seems because it requires v5 and right now we only support v3.2.4. CI complains about few things that has not been done in the repo, run |
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request does not have a backport label. Could you fix it @maguec? 🙏
NOTE: |
@maguec - Closing this one as there were no activity for a while |
What does this PR do?
Added Redis streams output to filebeat
Why is it important?
Redis outputs are already supported and streams is a new feature enabled in Redis 5+
Streams allow for an ordered persistent queue in Redis and is often used in data processing pipelines in more modern applications
Checklist
Author's Checklist
Check out the redis streams docs https://redis.io/topics/streams-intro
How to test this PR locally
Related issues
Supersedes (feature) add redis streams as an output #10703
Use cases
Logs
You can see the addition using redis-cli MONITOR command