Increase max cache size for scripts to try to stabilize Zeek tests #16390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
review
flaky-test
|
Pinging @elastic/siem (Team:SIEM) |
jsoriano
added
needs_backport
|
You can probably also increase the cache size to help. The cache size is 100 so it might be thrashing. Relates to #14236. |
Ok, trying this, thanks! |
|
jenkins, test this again please |
1 similar comment
|
jenkins, test this again please |
jsoriano
changed the title
|
jenkins, test this again please (builds were interrupted) |
|
@andrewkroh it seems that increasing the cache size actually works, tests with zeek files are not failing now. Thanks for the suggestion! |
|
jenkins, test this again, one last time |
kaiyan-sheng
approved these changes
Feb 19, 2020
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Feb 19, 2020
…lastic#16390) Some filebeat tests were frequently failing due to "Too many dynamic script compilations". Try to reduce number of compilations by increasing the max size of scripts cache. (cherry picked from commit 742e9e6)
jsoriano
removed
the
needs_backport
kvch
pushed a commit
to kvch/beats
that referenced
this pull request
Feb 20, 2020
…lastic#16390) Some filebeat tests were frequently failing due to "Too many dynamic script compilations". Try to reduce number of compilations by increasing the max size of scripts cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Increase max size of cache scripts to avoid recompilations in filebeat tests.
Why is it important?
Zeek tests are quite flaky since some time ago, the pipeline fails with: