-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update filebeat httpjson input to support pagination via Header and Okta module #16354
Update filebeat httpjson input to support pagination via Header and Okta module #16354
Conversation
Pinging @elastic/siem (Team:SIEM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to try to split some of these larger functions into some smaller ones that can be more easily unit tested. processHTTPRequest
is getting kind of long and doesn't have high test coverage.
- coverage-report.html.txt (added txt extension to be able to attach)
The new config parameters need to be added to the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issues with the changes 👍 . Can you please add some tests for the new features. The rate limiting, pagination, and config validation code doesn't get much exercise 🚲 in the tests. It might be easier to test some of cases if you can split the code into pieces that can be synchronously unit tested.
Thank you for adding config validation test cases. Are you able to add some test coverage for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding more tests. LGTM. Just one minor comment.
…upport pagination via Header and Okta module (elastic#17670) * Update filebeat httpjson input to support pagination via Header and Okta module (elastic#16354) * Update filebeat httpjson input to support pagination via Header and Okta module (cherry picked from commit 994e1f1) * Update CHANGELOG.next.asciidoc
Update filebeat httpjson input to support: