Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate ES client code from ES output code #16150

Merged
merged 91 commits into from
Mar 6, 2020
Merged

Separate ES client code from ES output code #16150

merged 91 commits into from
Mar 6, 2020

Commits on Mar 5, 2020

  1. Basic extraction of ES client code from ES output code

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    5cffba8 View commit details
    Browse the repository at this point in the history

  2. Move test

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    0b1603e View commit details
    Browse the repository at this point in the history

  3. Removing duplicate function in monitoring reporter

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    6d544b9 View commit details
    Browse the repository at this point in the history

  4. Break import cycle

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    84dff7a View commit details
    Browse the repository at this point in the history

  5. Guard onConnect callback execution

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    2f9b881 View commit details
    Browse the repository at this point in the history

  6. Replace use of field with getter

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    5c2e535 View commit details
    Browse the repository at this point in the history

  7. Moving common bulk API response processing into esclientleg

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    805469b View commit details
    Browse the repository at this point in the history

  8. Moving API integration tests

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    cdb59c1 View commit details
    Browse the repository at this point in the history

  9. Fixing references in tests

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f0946c2 View commit details
    Browse the repository at this point in the history

  10. Adding developer CHANGELOG entry

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    ce11c70 View commit details
    Browse the repository at this point in the history

  11. Move LoadJSON method

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    6c29542 View commit details
    Browse the repository at this point in the history

  12. Move callbacks to own file

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    b75c8c4 View commit details
    Browse the repository at this point in the history

  13. Move client-related constructors into client.go file

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f185aaa View commit details
    Browse the repository at this point in the history

  14. Reducing global logging usage

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    d9ea8da View commit details
    Browse the repository at this point in the history

  15. Use new constructor in test

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    a9c606b View commit details
    Browse the repository at this point in the history

  16. Passing logger in test

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    cc7e93e View commit details
    Browse the repository at this point in the history

  17. Use logger in test

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    6dc8b2b View commit details
    Browse the repository at this point in the history

  18. Use struct fieldnames when initializing

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    57864df View commit details
    Browse the repository at this point in the history

  19. Use constructor in test

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    d7f02af View commit details
    Browse the repository at this point in the history

  20. Fixing typos

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    13bbe68 View commit details
    Browse the repository at this point in the history

  21. Replace esclient.ParseProxyURL with generic function in common

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    9969cd0 View commit details
    Browse the repository at this point in the history

  22. Imports formatting

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    8446cd0 View commit details
    Browse the repository at this point in the history

  23. Moving more fields from ES output client to esclientleg.Connection

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    c0693e6 View commit details
    Browse the repository at this point in the history

  24. Moving more fields

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    5ef6784 View commit details
    Browse the repository at this point in the history

  25. Update test code

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    254b5e9 View commit details
    Browse the repository at this point in the history

  26. Use new TLS package

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    b4ec366 View commit details
    Browse the repository at this point in the history

  27. Extracting common test code into eslegtest package

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    3a85b3a View commit details
    Browse the repository at this point in the history

  28. Replace uses of elasticsearch output client with esclientleg.NewConne… 

    …ction
    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    fe0f221 View commit details
    Browse the repository at this point in the history

  29. Replacing uses of ES output client struct with esclientleg.Connection

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    eec5149 View commit details
    Browse the repository at this point in the history

  30. Handle callbacks

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    1c55cd2 View commit details
    Browse the repository at this point in the history

  31. Fixing formatting

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    b0d3767 View commit details
    Browse the repository at this point in the history

  32. Fixing import cycle

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    16069d7 View commit details
    Browse the repository at this point in the history

  33. Fixing import and package name

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    32c338d View commit details
    Browse the repository at this point in the history

  34. Fixing imports

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f83d0c1 View commit details
    Browse the repository at this point in the history

  35. More fixes

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    b3ded80 View commit details
    Browse the repository at this point in the history

  36. Breaking import cycle

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f4746aa View commit details
    Browse the repository at this point in the history

  37. Removing unused function

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    7b27826 View commit details
    Browse the repository at this point in the history

  38. Adding back missing statement

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    cc4bf48 View commit details
    Browse the repository at this point in the history

  39. Fixing param

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    1af576b View commit details
    Browse the repository at this point in the history

  40. Fixing package name

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f55621c View commit details
    Browse the repository at this point in the history

  41. Include ES output plugin so it's registered

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    7b37e1f View commit details
    Browse the repository at this point in the history

  42. Proxy handling

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    c37ee06 View commit details
    Browse the repository at this point in the history

  43. Let Connection handle ProxyDisable setting

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    6b32d9b View commit details
    Browse the repository at this point in the history

  44. Only parse proxy field from config if set

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    2f39d6f View commit details
    Browse the repository at this point in the history

  45. Cast timeout ints

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    6acbb8d View commit details
    Browse the repository at this point in the history

  46. Parse proxy URL

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    32836d5 View commit details
    Browse the repository at this point in the history

  47. Fixing proxy integration test

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    b6edfc4 View commit details
    Browse the repository at this point in the history

  48. Fixing ILM test

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    1e3a37a View commit details
    Browse the repository at this point in the history

  49. Updating expected request count in test

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    bc1d1a7 View commit details
    Browse the repository at this point in the history

  50. Fixing package names

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    144e7c4 View commit details
    Browse the repository at this point in the history

  51. Lots more refactoring!!!

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    76f2ddb View commit details
    Browse the repository at this point in the history

  52. Move timeout field

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    7be3905 View commit details
    Browse the repository at this point in the history

  53. More fixes

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    7f9b52d View commit details
    Browse the repository at this point in the history

  54. Adding missing files

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    9a0549e View commit details
    Browse the repository at this point in the history

  55. No need to pass HTTP any more

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f10972e View commit details
    Browse the repository at this point in the history

  56. Simplifying Bulk API usage

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    95f75b0 View commit details
    Browse the repository at this point in the history

  57. Removing unused code

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    9915ab3 View commit details
    Browse the repository at this point in the history

  58. Remove bulk state from Connection

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    9114f96 View commit details
    Browse the repository at this point in the history

  59. Removing empty file

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    c3ee320 View commit details
    Browse the repository at this point in the history

  60. Moving Bulk API response streaming parsing code back into ES output p… 

    …ackage
    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    8fbcbce View commit details
    Browse the repository at this point in the history

  61. Don't make monitoring bulk parsing code use streaming parser

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    c0c42e0 View commit details
    Browse the repository at this point in the history

  62. Replacing old HTTP struct passing

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    fd4ccbf View commit details
    Browse the repository at this point in the history

  63. Removing HTTP use

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    0b870bd View commit details
    Browse the repository at this point in the history

  64. Adding build tag

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    8f2f34b View commit details
    Browse the repository at this point in the history

  65. Fixing up tests

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    1cfd53b View commit details
    Browse the repository at this point in the history

  66. Allow default scheme to be configurable

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    a0144ea View commit details
    Browse the repository at this point in the history

  67. Adding versions to import paths

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    1139429 View commit details
    Browse the repository at this point in the history

  68. Remove redundant check

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    3da06a3 View commit details
    Browse the repository at this point in the history

  69. Undoing unnecessary heartbeat import change

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    82c8c53 View commit details
    Browse the repository at this point in the history

  70. Forgot to resolve conflicts

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f899879 View commit details
    Browse the repository at this point in the history

  71. Fixing imports

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    4d2a867 View commit details
    Browse the repository at this point in the history

  72. Running go mod tidy

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    9443e04 View commit details
    Browse the repository at this point in the history

  73. Revert "Remove redundant check" 

    This reverts commit c5fde6ff3be765a89c0bc20f9cae8f697d08d47e.
    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    fdd2131 View commit details
    Browse the repository at this point in the history

  74. Fixing args order

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f5c7ac6 View commit details
    Browse the repository at this point in the history

  75. Removing extraneous parameter

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    b0e3dfb View commit details
    Browse the repository at this point in the history

  76. Removing wrong errors package import

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    29b817c View commit details
    Browse the repository at this point in the history

  77. Fixing order of arguments

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    c77351c View commit details
    Browse the repository at this point in the history

  78. Fixing package name

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    9d3869d View commit details
    Browse the repository at this point in the history

  79. Instantiating logger for tests

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    0c2a8b1 View commit details
    Browse the repository at this point in the history

  80. Making streaming JSON parser private to ES output package

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f74cc1a View commit details
    Browse the repository at this point in the history

  81. Detect and try to fix scheme before parsing URL

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    0234092 View commit details
    Browse the repository at this point in the history

  82. Making Connection private to ES output Client

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    32f0411 View commit details
    Browse the repository at this point in the history

  83. Update test

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    be64ba4 View commit details
    Browse the repository at this point in the history

  84. Replace client.Ping() calls with client.Connect() calls in test code

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    26c28f2 View commit details
    Browse the repository at this point in the history

  85. Updating tests

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    addcfd4 View commit details
    Browse the repository at this point in the history

  86. Removing usage of ES output from monitoring code!

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    6788cfd View commit details
    Browse the repository at this point in the history

  87. Using strings.Index instead of strings.SplitN

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    9de9b87 View commit details
    Browse the repository at this point in the history

  88. Return default config via function call

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    63664e5 View commit details
    Browse the repository at this point in the history

  89. Removing "escape hatch" method to expose underlying connection from E… 

    …S output client
    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    bfa05b7 View commit details
    Browse the repository at this point in the history

  90. Using client connection in tests

    @ycombinator
    ycombinator committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    a61779d View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Re-implement Test() method for ES output client

    @ycombinator
    ycombinator committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    a416cfd View commit details
    Browse the repository at this point in the history