Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #16004 to 7.x: [Metricbeat] Add collecting AuroraDB metrics in rds metricset #16071

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Cherry-pick #16004 to 7.x: [Metricbeat] Add collecting AuroraDB metrics in rds metricset #16071

merged 2 commits into from
Feb 4, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

Cherry-pick of PR #16004 to 7.x branch. Original message:

What does this PR do?

This PR is to add collecting AuroraDB metrics into rds metricset: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.Monitoring.html

How to test this PR locally

  1. create an AuroraDB service in AWS
  2. enable aws module
  3. change aws.yml config to:
- module: aws
  period: 5m
  credential_profile_name: elastic-test
  metricsets:
    - rds
  1. You should see rds metrics from AuroraDB like:
    aws.rds.aurora_bin_log_replica_lag, aws.rds.aurora_replica.lag.ms, aurora_replica.lag_max.ms and etc.

Related issues

@kaiyan-sheng
[Metricbeat] Add collecting AuroraDB metrics in rds metricset (#16004)
8e46b8e 
* Add collecting AuroraDB metrics in rds metricset

* update changelog

* Rename to use iops as unit

* run mage fmt update

(cherry picked from commit 1e024a5)
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner February 4, 2020 15:56
@kaiyan-sheng kaiyan-sheng self-assigned this Feb 4, 2020
sayden
sayden approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng
Copy link
Contributor Author

#16078 is also backported in this PR.

@kaiyan-sheng kaiyan-sheng merged commit 75424ea into elastic:7.x Feb 4, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_16004_7.x branch February 4, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaiyan-sheng @sayden