Remove OneOfOne xxhash in favor of cespare #15518
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| @@ -51,3 +51,7 @@ func (f *hashMethod) Unpack(str string) error { | |||
| *f = m | |||
| return nil | |||
| } | |||
|
|
|||
| func newXxHash() hash.Hash { | |||
There was a problem hiding this comment.
Could you add a comment here as to why this wrapper function is necessary, especially since one isn't necessary for the other hash methods? I just put up cespare/xxhash#36; if/when that is merged and released, we won't need this wrapper function here.
There was a problem hiding this comment.
Looks like cespare/xxhash#36 won't be merged. So no point mentioning it in a comment, but I think it would still be good to have a comment here about the need for the wrapper.
|
jenkins, test this |
vjsamuel
force-pushed
the
move_to_cespare
branch
from
11df428 to
4c11b72
Compare
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
|
Travis CI is green. Jenkins CI failures are unrelated. Merging. |
Before this PR we had two implementations of xxhash in the codebase:
cespare/xxhashandOneOfOne/xxhash.This PR standardizes on the
cespare/xxhashimplementation.