-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-txfile and dependencies #15338
Conversation
- github.com/theckman/go-flock has been renamed to github.com/gofrs/flock - go-txfile now relies on flock project on all platforms: Always creates a lock file - go-txfile returns and error and does not block anymore if the lock file is taken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've reviewed the other changes.
@ph fyi; Partially improves #10653, but beats spooling support can not distinguish between starting a Beat or just testing some configuration. Instead of hanging, the test config command will return an error if the spool file is used by a concurrently running Beat. I wonder if this can affect the Agent. |
I think it could in a bad way, spooling to disk and upgrade path would be a pain. I need to create a followup issue on this problem. |
* Update go-txfile and dependencies - github.com/theckman/go-flock has been renamed to github.com/gofrs/flock - go-txfile now relies on flock project on all platforms: Always creates a lock file - go-txfile returns and error and does not block anymore if the lock file is taken (cherry picked from commit 79ec5c9)
- github.com/theckman/go-flock has been renamed to github.com/gofrs/flock - go-txfile now relies on flock project on all platforms: Always creates a lock file - go-txfile returns and error and does not block anymore if the lock file is taken (cherry picked from commit 79ec5c9)
Testing notes (from conversation with @urso):
|
github.com/gofrs/flock
a lock file
taken