Read build args for metricbeat system tests from file #14520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new file is being added to add information about the supported versions of a service, use this file to obtain the build args for docker images needed by metricbeat system tests.
jsoriano
commented
Nov 14, 2019
| - {'MYSQL_VARIANT': 'percona', 'MYSQL_VERSION': '8.0.13-4'} | ||
| - {'MYSQL_VARIANT': 'mariadb', 'MYSQL_VERSION': '10.2.23'} | ||
| - {'MYSQL_VARIANT': 'mariadb', 'MYSQL_VERSION': '10.3.14'} | ||
| - {'MYSQL_VARIANT': 'mariadb', 'MYSQL_VERSION': '10.4.4'} |
There was a problem hiding this comment.
@mdelapenya when we agree on the format and location of this file I will open this for review.
There was a problem hiding this comment.
I have moved these files to the _meta directory of each module as in #14355.
mdelapenya
reviewed
Nov 15, 2019
mdelapenya
reviewed
Nov 15, 2019
|
jenkins, test this again please |
|
jenkins, test this again please |
7 tasks
exekias
approved these changes
Nov 19, 2019
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Nov 19, 2019
A new file is being added to add information about the supported versions of a service, use this file to obtain the build args for docker images needed by metricbeat system tests. Python tests can now be decorated using the parameterized library instead of manually copying them. MySQL test files and docker compose definition has been moved to its own directory. (cherry picked from commit 9913bbf)
jsoriano
added a commit
that referenced
this pull request
Nov 20, 2019
A new file is being added to add information about the supported versions of a service, use this file to obtain the build args for docker images needed by metricbeat system tests. Python tests can now be decorated using the parameterized library instead of manually copying them. MySQL test files and docker compose definition has been moved to its own directory. (cherry picked from commit 9913bbf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new file is being added to add information about the supported
versions of a service, use this file to obtain the build args for
docker images needed by metricbeat system tests.
Python tests can now be decorated using the parameterized library
instead of manually copying them.
MySQL test files and docker compose definition has been moved
to its own directory.
More context about this change in #14355 (comment).