Fix: nginx module can't handle multiline entries #14499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
added
Team:Integrations
mtojek
force-pushed
the
14349-nginx-multiline-entries
branch
from
79243e3 to
f7cb7d1
Compare
exekias
added
review
needs_backport
mtojek
force-pushed
the
14349-nginx-multiline-entries
branch
from
f7cb7d1 to
6b31262
Compare
exekias
suggested changes
Nov 13, 2019
There was a problem hiding this comment.
This is looking great! Could you please add a new test file under nginx/error/test folder? You should then be able to generate the expected files with
GENERATE=1 INTEGRATION_TESTS=1 BEAT_STRICT_PERMS=false TESTING_FILEBEAT_MODULES=nginx nosetests tests/system/test_modules.py
Also please update CHANGELOG.next.asciidoc
|
Thank you @exekias for your hints. I've updated the PR with an adjusted ingest pipeline, corresponding test case and CHANGELOG. |
|
jenkins, test this again |
mtojek
force-pushed
the
14349-nginx-multiline-entries
branch
from
38192f8 to
6374e64
Compare
exekias
approved these changes
Nov 14, 2019
|
This will need backport to 7.x, please use the |
mtojek
pushed a commit
to mtojek/beats
that referenced
this pull request
Nov 14, 2019
* Fix: nginx module can't handle multiline entries * Update ingest pipeline and test case * Update next CHANGELOG (cherry picked from commit 72f2bf9)
mtojek
added a commit
that referenced
this pull request
Nov 14, 2019
mtojek
removed
the
needs_backport
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing config definition for multiline log entries.
Seen in #14349, where the setup includes nginx and PHP-FPM.