Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for heartbeat hints builder #14365

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Add docs for heartbeat hints builder #14365

merged 1 commit into from
Apr 17, 2020

Conversation

vjsamuel
Copy link
Contributor

@vjsamuel vjsamuel commented Nov 1, 2019

Apologies for not doing this sooner. @andrewvc

@vjsamuel vjsamuel requested a review from a team as a code owner November 1, 2019 05:23
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jsoriano jsoriano added docs Heartbeat needs_backport PR is waiting to be backported to other branches. review labels Nov 15, 2019
@jsoriano
Copy link
Member

I think Andrew already added some docs, @andrewvc would you like to take a look to this PR in case we can add something to the docs we have?

@vjsamuel
Copy link
Contributor Author

@jsoriano using some of the examples in this PR might be useful especially while running in a kubernetes environment. if it makes sense, I can rebase and try to add content of my PR into the current docs. thoughts?

cc: @exekias

@jsoriano
Copy link
Member

@vjsamuel this would be great, thanks!

@dedemorton
Copy link
Contributor

bump. This has been open for awhile. Do you plan to finalize the changes, or should I take this over?

@vjsamuel
Copy link
Contributor Author

vjsamuel commented Mar 3, 2020

@dedemorton i can clean this up and submit it by end of week.

@dedemorton
Copy link
Contributor

@vjsamuel Any progress? I know that these are extraordinary times. Let me know if I can do anything to help you move this forward. Thanks!

@vjsamuel vjsamuel force-pushed the heartbeat_docs branch 2 times, most recently from 2bed7d8 to b4eee83 Compare April 9, 2020 06:08
@vjsamuel
Copy link
Contributor Author

vjsamuel commented Apr 9, 2020

@dedemorton thanks for the patience. i have rebased and added in the docs. let me know if more of the old documentation could be reused.

@dedemorton
Copy link
Contributor

The doc changes LGTM from an editorial perspective.

@exekias or @jsoriano Can you approve the technical accuracy of the changes? Thanks!

@dedemorton
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@dedemorton
Copy link
Contributor

@Jenkins test this

@dedemorton
Copy link
Contributor

jenkins run the tests please

jsoriano
jsoriano reviewed Apr 15, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the configs, but they look good. Thanks!

dedemorton
dedemorton approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this work!

@dedemorton
Copy link
Contributor

jenkins run the tests please

@dedemorton dedemorton merged commit 9957775 into elastic:master Apr 17, 2020
@andrewvc
Copy link
Contributor

Thanks for bringing this one into the repo everyone! It is much appreciated.

dedemorton pushed a commit to dedemorton/beats that referenced this pull request Apr 18, 2020
@vjsamuel @dedemorton
Add hints based autodiscover docs for heartbeat (elastic#14365)
239bed0
@dedemorton dedemorton mentioned this pull request Apr 18, 2020
Merged
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Apr 18, 2020
@vjsamuel @dedemorton
Add hints based autodiscover docs for heartbeat (elastic#14365)
83dbdc8
@dedemorton dedemorton mentioned this pull request Apr 18, 2020
Merged
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Apr 18, 2020
@vjsamuel @dedemorton
Add hints based autodiscover docs for heartbeat (elastic#14365)
4b6fc4c
@dedemorton dedemorton mentioned this pull request Apr 18, 2020
Merged
@dedemorton
Copy link
Contributor

I went ahead and backported this change to get it into versioned branches. Thanks!

@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Apr 18, 2020
dedemorton added a commit that referenced this pull request Apr 18, 2020
@dedemorton @vjsamuel
Add hints based autodiscover docs for heartbeat (#14365) (#17816)
79bfb64 
Co-authored-by: Vijay Samuel <vjsamuel@ebay.com>
dedemorton added a commit that referenced this pull request Apr 18, 2020
@dedemorton @vjsamuel
Add hints based autodiscover docs for heartbeat (#14365) (#17818)
f694522 
Co-authored-by: Vijay Samuel <vjsamuel@ebay.com>
dedemorton added a commit that referenced this pull request Apr 18, 2020
@dedemorton @vjsamuel
Add hints based autodiscover docs for heartbeat (#14365) (#17817)
9b381b1 
Co-authored-by: Vijay Samuel <vjsamuel@ebay.com>
@vjsamuel vjsamuel deleted the heartbeat_docs branch April 18, 2020 05:13
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@dedemorton @vjsamuel
Add hints based autodiscover docs for heartbeat (elastic#14365) (elas…
c0f062c 
…tic#17817)

Co-authored-by: Vijay Samuel <vjsamuel@ebay.com>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@dedemorton @vjsamuel
Add hints based autodiscover docs for heartbeat (elastic#14365) (elas…
9ed5f15 
…tic#17816)

Co-authored-by: Vijay Samuel <vjsamuel@ebay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias left review comments

@jsoriano jsoriano jsoriano approved these changes

@dedemorton dedemorton dedemorton approved these changes

Assignees
No one assigned
Labels
docs Heartbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vjsamuel @elasticmachine @jsoriano @dedemorton @andrewvc @exekias @andresrc