Enhance testing and build environment #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ruflin
commented
Apr 19, 2016
ruflin
commented
- Use same base environment for manual and automated testing
- Allow to run testsuite with different environment
- Document environments and usage
|
Can you check if the travis failure is relevant? |
|
@tsg Potentially related as a restart also didn't help. Will look into it. Could be related to Shield in snapshot. |
|
After restarting the build several time it crashes every time but at different stages. Feels like this is a Travis problem? Will investigate further. |
ruflin
force-pushed
the
build-improvements
branch
from
47c2c69 to
59aff9b
Compare
|
This will need a rebase after #1445 is merged |
ruflin
force-pushed
the
build-improvements
branch
4 times, most recently
from
e7b5a2c to
f0eeff7
Compare
* Use same base environment for manual and automated testing * Allow to run testsuite with different environment * Document environments and usage * Increment time waiting for elasticsearch because of travis * Introduce snapshot dockerfiles for logstash and kibana * Update travis to most recent docker version (1.11.0) and docker-compose version (1.7.0) * Introduce DOCKER_CACHE option to be used by jenkins to not cache build images
ruflin
force-pushed
the
build-improvements
branch
from
32e12cb to
f01ed11
Compare
Current coverage is 33.34%@@ master #1420 diff @@
==========================================
Files 27 55 +28
Lines 1916 4238 +2322
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 769 1413 +644
- Misses 1091 2717 +1626
- Partials 56 108 +52
|
| @@ -58,6 +58,10 @@ addons: | |||
| - geoip-database | |||
|
|
|||
| before_install: | |||
| # Update to most recent docker version | |||
| - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then sudo apt-get update ; fi | |||
There was a problem hiding this comment.
You don't need three separate if checks. These can be combined to:
- if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then
sudo apt-get update;
sudo apt-cache search docker;
sudo apt-get -o Dpkg::Options::="--force-confnew" install -y docker-engine;
fi
|
LGTM, just a few mostly cosmetic issues. |
|
Adjustments were pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.