Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Changes to support the split of the Metrics Guide and the Logs Guide #14158

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

Titch990
Copy link
Contributor

@Titch990 Titch990 commented Oct 21, 2019

Changes required as a consequence of splitting the Infrastructure Monitoring Guide into two books, the Logs Monitoring Guide and the Metrics Monitoring Guide.

Note that this is one of four linked PRs, which need to be merged together to avoid build failures.
elastic/stack-docs#581
elastic/docs#1312
elastic/kibana#48633
#14158 (this one!)

DO NOT MERGE UNTIL EVERYTHING IS READY

@Titch990
Copy link
Contributor Author

Note that this is one of four linked PRs, which need to be merged together to avoid build failures.

elastic/stack-docs#581
elastic/docs#1312
elastic/kibana#48633
#14158 (this one)

DO NOT MERGE UNTIL EVERYTHING IS READY

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the attributes resolve to the correct URLs for each book that you have added here.

@nik9000
Copy link
Member

nik9000 commented Oct 24, 2019

@elasticmachine, run elasticsearch-ci/docs

1 similar comment
@Titch990
Copy link
Contributor Author

@elasticmachine, run elasticsearch-ci/docs

@Titch990
Copy link
Contributor Author

Jenkins retest please

@ycombinator
Copy link
Contributor

Jenkins CI failures are unrelated to the changes in this PR. Some are currently happening on master as well and some are due to flaky tests. So this PR is good to merge once the Travis CI build is complete and the docs job in it passes, just like it has in the Jenkins CI build.

@Titch990 Titch990 merged commit a990abe into elastic:master Oct 28, 2019
@Titch990 Titch990 deleted the MJ-inframon-split branch October 28, 2019 12:29
urso pushed a commit to urso/beats that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants