Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip libbeat logstash output tests until Logstash ES output plugin is updated #14094

Merged
merged 5 commits into from
Oct 16, 2019
Merged

Skip libbeat logstash output tests until Logstash ES output plugin is updated #14094

merged 5 commits into from
Oct 16, 2019

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Oct 16, 2019

The libbeat CI build is failing like so:

07:40:09 command [go test -race -tags integration -cover -coverprofile /tmp/gotestcover-111073901 github.com/elastic/beats/libbeat/outputs/logstash]: exit status 1
07:40:09 --- FAIL: TestSendMessageViaLogstashTCP (5.80s)
07:40:09     logstash_integration_test.go:312: wrong number of results: 0
07:40:09 make: *** [integration-tests] Error 1
07:40:09 --- FAIL: TestSendMessageViaLogstashTLS (6.42s)
07:40:09     logstash_integration_test.go:312: wrong number of results: 0
07:40:09 --- FAIL: TestSendMultipleViaLogstashTCP (5.90s)
07:40:09     logstash_integration_test.go:348: wrong number of results: 0
07:40:09 --- FAIL: TestSendMultipleViaLogstashTLS (6.57s)
07:40:09     logstash_integration_test.go:348: wrong number of results: 0

This is happening because the elasticsearch output plugin in Logstash needs to be updated. See logstash-plugins/logstash-output-elasticsearch#887 for details.

This PR skips the failing tests until the update has been made. It also removes the document_type setting from the elasticsearch output in the Logstash pipeline used by these tests.

@ycombinator ycombinator changed the title Remove document_type setting from test LS pipeline Skip libbeat logstash output tests until Logstash ES output plugin is updated Oct 16, 2019
@ycombinator ycombinator requested a review from a team October 16, 2019 19:07
@ycombinator ycombinator marked this pull request as ready for review October 16, 2019 19:07
@urso
Copy link

urso commented Oct 16, 2019

Uff, that's a tough one. This means we have no Beats->LS integration tests anymore. Please create follow up issue that we must undo the change ASAP.

@ycombinator
Copy link
Contributor Author

Please create follow up issue that we must undo the change ASAP.

Done: #14100

@ycombinator
Copy link
Contributor Author

Travis CI is green. Jenkins CI failures are Metricbeat module system tests, which are unrelated to this change. So merging this PR now.

@ycombinator ycombinator merged commit 82cc404 into elastic:master Oct 16, 2019
@ycombinator ycombinator deleted the libbeat-fix-ls-es-output branch October 16, 2019 23:50
jorgemarey pushed a commit to jorgemarey/beats that referenced this pull request Jun 8, 2020
… updated (elastic#14094)

* Remove `document_type` setting from test LS pipeline

* Skip tests until LS output plugin is updated

* Skipping more tests

* Skip more tests

* Skipping one more test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants