Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack: fix dropped errors #13773

Merged
merged 1 commit into from
Jan 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-developer.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,4 @@ The list below covers the major changes between 7.0.0-rc2 and master only.
- Compare event by event in `testadata` framework to avoid sorting problems {pull}13747[13747]
- Added a `default_field` option to fields in fields.yml to offer a way to exclude fields from the default_field list. {issue}14262[14262] {pull}14341[14341]
- `supported-versions.yml` can be used in metricbeat python system tests to obtain the build args for docker compose builds. {pull}14520[14520]
- Fix dropped errors in the tests for the metricbeat Azure module. {pull}13773[13773]
3 changes: 3 additions & 0 deletions x-pack/metricbeat/module/azure/compute_vm/compute_vm_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ func TestFetch(t *testing.T) {
t.Fatal(err)
}
module, metricsets, err = mb.NewModule(c, mb.Registry)
if err != nil {
kaiyan-sheng marked this conversation as resolved.
Show resolved Hide resolved
t.Fatal(err)
}
assert.NotNil(t, module)
assert.NotNil(t, metricsets)
ms, ok = metricsets[0].(*MetricSet)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ func TestFetch(t *testing.T) {
t.Fatal(err)
}
module, metricsets, err = mb.NewModule(c, mb.Registry)
if err != nil {
t.Fatal(err)
}
assert.NotNil(t, module)
assert.NotNil(t, metricsets)
ms, ok = metricsets[0].(*MetricSet)
Expand Down
3 changes: 3 additions & 0 deletions x-pack/metricbeat/module/azure/monitor/monitor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ func TestFetch(t *testing.T) {
t.Fatal(err)
}
module, metricsets, err = mb.NewModule(c, mb.Registry)
if err != nil {
t.Fatal(err)
}
assert.NotNil(t, module)
assert.NotNil(t, metricsets)
ms, ok := metricsets[0].(*MetricSet)
Expand Down