-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DNS header_flags, registered_domain, resolved_ip #13354
Merged
andrewkroh
merged 1 commit into
elastic:master
from
andrewkroh:feature/pb/ecs-dns-fields
Aug 27, 2019
Merged
Add DNS header_flags, registered_domain, resolved_ip #13354
andrewkroh
merged 1 commit into
elastic:master
from
andrewkroh:feature/pb/ecs-dns-fields
Aug 27, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DNS fields for ECS. This adds three fields: - dns.question.registered_domain - dns.header_flags - dns.resolved_ip Relates elastic#13320
andrewkroh
force-pushed
the
feature/pb/ecs-dns-fields
branch
from
August 27, 2019 00:12
8222524
to
5371ba4
Compare
Pinging @elastic/siem |
Sample event:
|
webmat
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
Are there golden files that could be updated? If not, the sample you shared with the PR is looking good 👍
There are no golden files used in automated testing that I'm aware of for this beat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DNS fields for ECS. This adds three fields:
Relates #13320