Change global_fields script so it doesn't produce a needless error message. #13281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
Metricbeat
|
There is a PR to fix this error with a bit more context here: #13266 |
|
Looks like the fix has already been merged in #13266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, when this script is run as part of
make updateit exits3and produces a kind of confusing error message. This is because the output defaults to-and then a laterLoadFieldsYamlwill fail after it tries to load-as a file path. This adds a little short circuit so we don't exit. I'm honestly not sure why the finalLoadFieldsYamlis here, but I figured I should take the least invasive route.