Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git archive to copy beats on community beats #13193

Merged
merged 5 commits into from
Aug 12, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Aug 7, 2019

Use git archive to copy beats, so unnecessary files
that are later removed are not copied, making the
process faster, specially on dirty working copies of
beats.

@jsoriano jsoriano added review :Generator Related to code generators for building custom Beats or modules. labels Aug 7, 2019
@jsoriano jsoriano self-assigned this Aug 7, 2019
@jsoriano jsoriano changed the title Use git archive to copy beats on generator Use git archive to copy beats on community beats Aug 7, 2019
CHANGELOG-developer.next.asciidoc Outdated Show resolved Hide resolved
@fearful-symmetry
Copy link
Contributor

yay, no more rsync! LGTM, but I don't have much experience with git archive.

@sayden sayden self-requested a review August 9, 2019 08:31
@jsoriano
Copy link
Member Author

jsoriano commented Aug 9, 2019

I am going to try to enable generator tests for OSX in travis before merging this #13210

@jsoriano jsoriano merged commit 979779f into elastic:master Aug 12, 2019
@jsoriano jsoriano deleted the generator-copy-vendor branch August 12, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Generator Related to code generators for building custom Beats or modules. review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants